Fuel for OpenStack

[upgrade] Puppet path hardcoded with incorrect release version

Bug #1544967 reported by Oleg S. Gelbukh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Critical
Oleg S. Gelbukh
Fuel for OpenStack 8.0-updates
7.0.x
Invalid
Critical
Registry Administrators
Fuel for OpenStack 7.0-updates

Bug Description

In fuel-octane, constant PUPPET_DIR contains the release version number 2015.1.0-7.0 which is incorrect for 8.0. This causes the 'octane fuel-restore' script to fail:

2016-02-12 13:07:35 ERROR octane.util.subprocess puppet[26072] stderr: Error: Could not run: Could not find file /etc/puppet/2015.1.0-7.0/modules/nailgun/e
xamples/host-only.pp

This constant has to be changed to point at /etc/puppet/modules which is a symlink to the latest version of puppet modules from fuel-library.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (master)

Fix proposed to branch: master
Review: https://review.openstack.org/280128

Changed in fuel:
assignee: Fuel Octane Dev Team (fuel-octane) → Oleg S. Gelbukh (gelbuhos)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/280177

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/280128
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=bde08a6c5d1e6107f1fe30cd138357d2e74ceb25
Submitter: Jenkins
Branch: master

commit bde08a6c5d1e6107f1fe30cd138357d2e74ceb25
Author: Oleg Gelbukh <email address hidden>
Date: Fri Feb 12 12:58:08 2016 +0000

    Remove version hardcode from puppet module path

    Now module path constant has hardcoded version 2015.1.0-7.0.
    Replace it with /etc/puppet/modules path which is a symlink
    to the current version of modules.

    Change-Id: I066750e8deb292fa8a34656d2bce06ef13719360
    Closes-bug: 1544967

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/280177
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=be95fb7597448d4ec4932a22b45451efb6978b99
Submitter: Jenkins
Branch: stable/8.0

commit be95fb7597448d4ec4932a22b45451efb6978b99
Author: Oleg Gelbukh <email address hidden>
Date: Fri Feb 12 12:58:08 2016 +0000

    Remove version hardcode from puppet module path

    Now module path constant has hardcoded version 2015.1.0-7.0.
    Replace it with /etc/puppet/modules path which is a symlink
    to the current version of modules.

    Change-Id: I066750e8deb292fa8a34656d2bce06ef13719360
    Closes-bug: 1544967

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/280617

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/280618

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/8.0)

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/281174

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/280618
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=87fd12eb8b228290c7e9a6765a0bd1c685e182d6
Submitter: Jenkins
Branch: master

commit 87fd12eb8b228290c7e9a6765a0bd1c685e182d6
Author: Oleg Gelbukh <email address hidden>
Date: Tue Feb 16 11:31:01 2016 +0000

    Remove --detailed-exitcodes flag from puppet agent

    Calling --detailed-exitcodes flag causes the puppet agent to
    exit with non-0 code upon successful execution (exit code 2) [1].

    Delete the flag from call to the puppet agent.

    [1] https://docs.puppetlabs.com/puppet/latest/reference/man/agent.html

    Change-Id: I84ed978bdb8b95dc3074ec544ff91f44f8f58f9e
    Related-bug: 1544967

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/281174
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=8516a995e3d0dca9efaed471476ce51886c2c333
Submitter: Jenkins
Branch: stable/8.0

commit 8516a995e3d0dca9efaed471476ce51886c2c333
Author: Oleg Gelbukh <email address hidden>
Date: Tue Feb 16 11:31:01 2016 +0000

    Remove --detailed-exitcodes flag from puppet agent

    Calling --detailed-exitcodes flag causes the puppet agent to
    exit with non-0 code upon successful execution (exit code 2) [1].

    Delete the flag from call to the puppet agent.

    [1] https://docs.puppetlabs.com/puppet/latest/reference/man/agent.html

    Change-Id: I84ed978bdb8b95dc3074ec544ff91f44f8f58f9e
    Related-bug: 1544967

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/280617
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=30b775d528805726104ceb5913ca66e03fb3d790
Submitter: Jenkins
Branch: master

commit 30b775d528805726104ceb5913ca66e03fb3d790
Author: Oleg Gelbukh <email address hidden>
Date: Tue Feb 16 11:23:28 2016 +0000

    Run puppet agent in the end of restore

    Add class for puppet agent run in octane.handlers.backup_restore.puppet
    module. Add this class to archivators pipeline in the end of the
    procedure. Call puppet agent for restore method only.

    Change-Id: I3809d2a4439d5d0866a7e29ee70a68e54c123c4f
    Related-bug: 1544967

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/8.0)

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/281966

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/281966
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=bf1bb9aab941116065bf4d376e2f1b83ae5e4ab8
Submitter: Jenkins
Branch: stable/8.0

commit bf1bb9aab941116065bf4d376e2f1b83ae5e4ab8
Author: Oleg Gelbukh <email address hidden>
Date: Tue Feb 16 11:23:28 2016 +0000

    Run puppet agent in the end of restore

    Add class for puppet agent run in octane.handlers.backup_restore.puppet
    module. Add this class to archivators pipeline in the end of the
    procedure. Call puppet agent for restore method only.

    Change-Id: I3809d2a4439d5d0866a7e29ee70a68e54c123c4f
    Related-bug: 1544967
    (cherry picked from commit 30b775d528805726104ceb5913ca66e03fb3d790)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/7.0)

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/282264

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/7.0)

Related fix proposed to branch: stable/7.0
Review: https://review.openstack.org/282296

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/7.0)

Reviewed: https://review.openstack.org/282264
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=9cf51987eeee9acfe2c75962781bd6fed6198b68
Submitter: Jenkins
Branch: stable/7.0

commit 9cf51987eeee9acfe2c75962781bd6fed6198b68
Author: Oleg Gelbukh <email address hidden>
Date: Fri Feb 12 12:58:08 2016 +0000

    Remove version hardcode from puppet module path

    Now module path constant has hardcoded version 2015.1.0-7.0.
    Replace it with /etc/puppet/modules path which is a symlink
    to the current version of modules.

    Change-Id: I066750e8deb292fa8a34656d2bce06ef13719360
    Closes-bug: 1544967
    (cherry picked from commit bde08a6c5d1e6107f1fe30cd138357d2e74ceb25)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/7.0)

Related fix proposed to branch: stable/7.0
Review: https://review.openstack.org/282325

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/7.0)

Reviewed: https://review.openstack.org/282296
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=8b679e3e16ba89c93d9447212faa743d9773c07f
Submitter: Jenkins
Branch: stable/7.0

commit 8b679e3e16ba89c93d9447212faa743d9773c07f
Author: Oleg Gelbukh <email address hidden>
Date: Tue Feb 16 11:31:01 2016 +0000

    Remove --detailed-exitcodes flag from puppet agent

    Calling --detailed-exitcodes flag causes the puppet agent to
    exit with non-0 code upon successful execution (exit code 2) [1].

    Delete the flag from call to the puppet agent.

    [1] https://docs.puppetlabs.com/puppet/latest/reference/man/agent.html

    Change-Id: I84ed978bdb8b95dc3074ec544ff91f44f8f58f9e
    Related-bug: 1544967
    (cherry picked from commit 8516a995e3d0dca9efaed471476ce51886c2c333)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/282325
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=9173ce5ff0044debff2de0e19408abef95c1d243
Submitter: Jenkins
Branch: stable/7.0

commit 9173ce5ff0044debff2de0e19408abef95c1d243
Author: Oleg Gelbukh <email address hidden>
Date: Tue Feb 16 11:23:28 2016 +0000

    Run puppet agent in the end of restore

    Add class for puppet agent run in octane.handlers.backup_restore.puppet
    module. Add this class to archivators pipeline in the end of the
    procedure. Call puppet agent for restore method only.

    Change-Id: I3809d2a4439d5d0866a7e29ee70a68e54c123c4f
    Related-bug: 1544967
    (cherry picked from commit 30b775d528805726104ceb5913ca66e03fb3d790)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.