Node could be assigned to nodegroup which uses another admin/PXE network

Bug #1513042 reported by Artem Panchenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
In Progress
Medium
Nikolay Tymtsiv
Mitaka
Won't Fix
Medium
Fuel Python (Deprecated)
Newton
In Progress
Medium
Nikolay Tymtsiv

Bug Description

Currently it's possible to assign node discovered in non-default PXE network to environment which doesn't use that network:

[root@nailgun ~]# fuel env
id | status | name | mode | release_id | pending_release_id
---|------------|-------------------------|------------|------------|-------------------
1 | deployment | TestMultipleClusterNets | ha_compact | 2 | None
2 | new | DefaultCluster | ha_compact | 2 | None
[root@nailgun ~]# fuel nodegroup
id | cluster | name
---|---------|---------------
1 | 1 | default
2 | 1 | group-custom-1
3 | 2 | default
[root@nailgun ~]# fuel network-group | grep admin
1 | fuelweb_admin | None | 10.109.25.0/24 | 10.109.25.1 | None
10 | fuelweb_admin | None | 10.109.30.0/24 | 10.109.30.2 | 2
[root@nailgun ~]# fuel nodes
id | status | name | cluster | ip | mac | roles | pending_roles | online | group_id
---|-------------|-------------------------|---------|-------------|-------------------|-----------------|---------------|--------|---------
3 | deploying | slave-03_controller | 1 | 10.109.25.4 | 64:fa:14:70:c4:71 | controller | | True | 1
2 | deploying | slave-01_controller | 1 | 10.109.25.3 | 64:e7:60:cb:1e:ec | controller | | True | 1
1 | ready | slave-05_controller | 1 | 10.109.25.5 | 64:e8:08:98:7c:6d | controller | | True | 1
5 | provisioned | slave-02_compute_cinder | 1 | 10.109.30.4 | 64:5e:dd:48:94:70 | cinder, compute | | True | 2
4 | provisioned | slave-04_compute_cinder | 1 | 10.109.30.3 | 64:99:6d:51:44:e6 | cinder, compute | | True | 2
6 | discover | Untitled (5a:e1) | None | 10.109.30.5 | 64:2d:83:ed:5a:e1 | | | True | None
[root@nailgun ~]# fuel --env 2 node set --node 6 --role controller
Nodes [6] with roles ['controller'] were added to environment 2
[root@nailgun ~]# fuel deploy-changes --env 2

Steps to reproduce:

1. Create environment #1
2. Create custom nodegroup for the environment
3. Bootstrap slave node from custom nodegroup
4. Create another environment (with 1 default nodegroup) #2
5. Assign nodes (bootstrapped on step #3) to the environment #2

Expected result: node additioning failed, because the environment doesn't have suitable nodegroup for it

Actual result: node is added to the environment, deployment could be started

Revision history for this message
Artem Panchenko (apanchenko-8) wrote :
Dmitry Klenov (dklenov)
tags: added: area-python
Changed in fuel:
importance: Undecided → Medium
status: New → Confirmed
Dmitry Pyzhov (dpyzhov)
tags: added: feature-nodegroup
Dmitry Pyzhov (dpyzhov)
tags: added: team-network
Revision history for this message
Alexander Kislitsky (akislitsky) wrote :

We passed SCF in 8.0. Moving the bug to 9.0.

Changed in fuel:
milestone: 8.0 → 9.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/350420

Changed in fuel:
assignee: l23network (l23network) → Nikolay Tymtsiv (ntymtsiv)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/350420
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.