fuel-library ci should validate Puppetfile only contains tags

Bug #1501379 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Alex Schultz
7.0.x
Won't Fix
High
Alex Schultz

Bug Description

In order to enforce our policy[0] of only having tags in the Puppetfile for fuel-library, we should have a CI tasks that will -1 if a branch or hash is referenced.

[0] https://wiki.openstack.org/wiki/Fuel/Library_and_Upstream_Modules#librarian-puppet-simple_integration

Changed in fuel:
importance: Critical → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/229605

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to fuel-infra/jenkins-jobs (master)

Fix proposed to branch: master
Change author: Alex Schultz <email address hidden>
Review: https://review.fuel-infra.org/12344

tags: added: devops
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/229605
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=0701e2b9b20e3d4e931893a3087cebbf3785d201
Submitter: Jenkins
Branch: master

commit 0701e2b9b20e3d4e931893a3087cebbf3785d201
Author: Alex Schultz <email address hidden>
Date: Wed Sep 30 15:31:15 2015 -0500

    Add Puppetfile validator script for Jenkins

    This change adds a Puppetfile validator script that can be used by
    jenkins to ensure that all Puppetfile entries are properly formated and
    reference a tag based on our policies.

    Change-Id: I623929df3a309110d26e166ac9067c715b14188b
    Partial-Bug: #1501379

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to fuel-infra/jenkins-jobs (master)

Reviewed: https://review.fuel-infra.org/12344
Submitter: Igor Belikov <email address hidden>
Branch: master

Commit: 297e923437e7b9df8d2c03a3514277e68643d4a4
Author: Alex Schultz <email address hidden>
Date: Thu Oct 8 17:42:54 2015

Add fuel-library Puppetfile validator job

This change adds a job to run a Puppetfile validator script to ensure
that it is properly formated and references a tag and not a branch or
git hash. The job is non-voting initially.

Change-Id: I31191fffd993af51b940b719cdd67deccdea5b92
Closes-Bug: #1501379

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
tags: added: area-library
Dmitry Pyzhov (dpyzhov)
tags: added: tech-debt
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.