Fuel for OpenStack

[nailgun] Fix comments in https://review.openstack.org/201217/

Bug #1477648 reported by Aleksey Kasatkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Aleksey Kasatkin
Fuel for OpenStack 10.0
8.0.x
Won't Fix
Medium
Aleksey Kasatkin
Fuel for OpenStack 8.0
Mitaka
Won't Fix
High
Aleksey Kasatkin
Fuel for OpenStack 9.0

Bug Description

Please look into https://review.openstack.org/#/c/201217/ for details.
It was merged with non-critical comments.

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 8.0
Aleksey Kasatkin (alekseyk-ru)
tags: added: tech-debt
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

We shouldn't postpone review comments for a year. Raising priority to High, please fix it in 9.0.

Changed in fuel:
milestone: 8.0 → 9.0
importance: Medium → High
Revision history for this message
Bug Checker Bot (esikachev-l) wrote : Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info
Bug Checker Bot (bug-checker)
tags: removed: need-info
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/307624

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

To be done according to comments:

1. Add schema validation into NetworkGroup API validator.
2. Remove useless code from objects.NetworkGroup.get_from_node_group_by_name method.
3. Fix name of the test in unit/test_migration_fuel_7_0.TestStringNetworkGroupName

Fuel Devops McRobotson (fuel-devops-robot)
Changed in fuel:
milestone: 9.0 → 10.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-fuelclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/308391

Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

Technical debt, doesn't affect real users. Removing from Mitaka release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/308391
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=12de059d8a605acc494d5312c4683d09ab333d0a
Submitter: Jenkins
Branch: master

commit 12de059d8a605acc494d5312c4683d09ab333d0a
Author: Aleksey Kasatkin <email address hidden>
Date: Wed Apr 20 17:57:26 2016 +0300

    Change node group id in test

    as "0" will not pass JSON schema validation and error message will be
    different (when JSON schema validation for NetworkGroup will be merged
    into Nailgun).

    Change-Id: I44be6ea10359cd6047f447860967882aea050867
    Related-Bug: 1477648

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/307624
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5263334f4f790d21e784e5424029b81445522c57
Submitter: Jenkins
Branch: master

commit 5263334f4f790d21e784e5424029b81445522c57
Author: Aleksey Kasatkin <email address hidden>
Date: Tue Apr 19 10:55:35 2016 +0300

    Fix minor comments in NetworkGroup API code request

    Fix for comments in https://review.openstack.org/#/c/201217/12

    1. Add schema validation into NetworkGroup API validator.
    2. Slight refactoring of objects.NetworkGroup methods.
    3. Fix name of the test in unit/test_migration_fuel_7_0.TestStringNetworkGroupName
    And fix corresponding tests in unit/test_network_group_handler

    Change-Id: If2863c2bbf270f85a74cc784fa06844d710feb4d
    Closes-Bug: #1477648
    Related-Bug: #1484929

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.