Fuel for OpenStack

IBP ignore 255 exit code from e2fsck

Bug #1452277 reported by Vladimir Kozhukalov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Sebastian Kalinowski
Fuel for OpenStack 6.1

Bug Description

Sometimes, when slave nodes aren't synchronized with the master node we can end up with the images built in the future. When you put this image on a hard drive and then run e2fsck it fails with 255 exit code which we probably need to ignore to avoid deployment failing caused by ntp issues.

Vladimir Sharshov (vsharshov)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Fuel provisioning team (fuel-provisioning)
Sebastian Kalinowski (prmtl)
Changed in fuel:
assignee: Fuel provisioning team (fuel-provisioning) → Sebastian Kalinowski (prmtl)
status: Triaged → In Progress
Revision history for this message
Sebastian Kalinowski (prmtl) wrote :

Ignoring exit code it's probably not the best idea since 255 is not an exit code connected with this issue [1]
We can try to ignore e2fsck issues regarding to mount times in future using [2] (and [3]) in /etc/e2fsck.conf similar to this: http://paste.openstack.org/show/220654/

[1] http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/tree/e2fsck/e2fsck.h#n73
[2] http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/tree/e2fsck/problem.c#n338 (PR_0_FUTURE_SB_LAST_MOUNT)
[3] http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/tree/e2fsck/problem.h#n191 (PR_0_FUTURE_SB_LAST_MOUNT)

Revision history for this message
Vladimir Kozhukalov (kozhukalov) wrote :

Sebastian,

Great findings. It sounds much more rational to have this in the config rather than somewhere in the code.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/182587

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/182587
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=b1df628b0d8d77d6baf8dad1fead812b6e26f0e7
Submitter: Jenkins
Branch: master

commit b1df628b0d8d77d6baf8dad1fead812b6e26f0e7
Author: Sebastian Kalinowski <email address hidden>
Date: Wed May 13 11:08:52 2015 +0200

    Ignore time shifts in e2fsck on bootstrap

    Added /etc/e2fsck.conf with ignoring of problems related with
    time shifts between Fuel Master and bootstraped nodes.

    Ignoring two problems:
     * PR_0_FUTURE_SB_LAST_WRITE (0x000032) - Last write time is in the future
     * PR_0_FUTURE_SB_LAST_MOUNT (0x000031) - Last mount time is in the future

    Change-Id: Ie75538b92af9fdda0078a0a35799da5cde313fa5
    Closes-Bug: #1452277

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.