l23network has permanently failed unit-test for collected property "routes"

Bug #1449127 reported by Sergey Vasilenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Sergey Vasilenko

Bug Description

l23network has permanently failed unit-test for collected property "routes"

This happens, because 'routes' property never pass from manifests, but collected in generate() method of custom type.

We should investigate how-to make unit-tests for such situations.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/177858

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/177858
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=909f6bb58c1853a710bbfc01da7763f2c9a5640f
Submitter: Jenkins
Branch: master

commit 909f6bb58c1853a710bbfc01da7763f2c9a5640f
Author: Sergey Vasilenko <email address hidden>
Date: Mon Apr 27 19:22:30 2015 +0300

    Temporary disable permanently failed unit test.

    due we should investigate how-to make tests for auto-learning in generate() properties.
    Classic puppet-rspec not enough for this situation.

    Change-Id: I2727bab3b7fc200526ec686027ed58b86eb383ec
    Related-bug: #1449127

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/177937

Changed in fuel:
assignee: Dmitry Ilyin (idv1985) → Sergey Vasilenko (xenolog)
status: New → In Progress
Changed in fuel:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/177937
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=ebc4a8cc490ca221b1b6cafc75037d3441c632cf
Submitter: Jenkins
Branch: master

commit ebc4a8cc490ca221b1b6cafc75037d3441c632cf
Author: Sergey Vasilenko <email address hidden>
Date: Mon Apr 27 22:25:23 2015 +0300

    Test for collected routes

    + correct readme to current implementation

    Change-Id: I366b0c774fbeb62f67df9ad95c57eabf4cdf73fc
    Closes-bug: #1449127

Changed in fuel:
status: In Progress → Fix Committed
tags: added: 6.1-mu-1
tags: added: non-release
Changed in fuel:
milestone: 6.1-updates → 6.1-mu-1
Revision history for this message
Vitaly Sedelnik (vsedelnik) wrote :

This is unit test issue which doesn't affect end users - no need to include into 6.1-mu-1, targetting to 6.1-updates

Changed in fuel:
milestone: 6.1-mu-1 → 6.1-updates
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.