Fuel for OpenStack

Typo in logrotate template causes issue with hourly rotations at nodes

Bug #1393495 reported by Bogdan Dobrelya
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Bogdan Dobrelya
Fuel for OpenStack 6.0
5.0.x
Won't Fix
High
Fuel Library (Deprecated)
Fuel for OpenStack 5.0-updates
5.1.x
Fix Released
High
Bogdan Dobrelya
Fuel for OpenStack 5.1.1
6.0.x
Fix Committed
High
Bogdan Dobrelya
Fuel for OpenStack 6.0

Bug Description

File https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/openstack/templates/20-fuel.conf.erb#L29 should be fixed by moving the comment into the {} stanza.

Otherwise, some log files at Openstack nodes cannot be rotated at the hourly schedule and /var/log could end up having no free space while waiting for the next daily based rotation schedule.

See original description
Bogdan Dobrelya (bogdando)
Changed in fuel:
importance: Undecided → High
milestone: none → 6.0
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/135025

Changed in fuel:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/5.0)

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/135027

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/5.1)

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/135028

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/135025
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=d02186e0aa7e7eddb1edacbd57efc34cac7ec254
Submitter: Jenkins
Branch: master

commit d02186e0aa7e7eddb1edacbd57efc34cac7ec254
Author: Bogdan Dobrelya <email address hidden>
Date: Mon Nov 17 18:32:54 2014 +0100

    Fix comments in logrotation templates

    W/o this fix, some log files at Openstack nodes cannot be rotated at the
    hourly schedule and /var/log could end up having no free space while
    waiting for the next daily based rotation schedule.

    Closes-bug: #1393495

    Change-Id: I192ebbd31f83fb264307c1c2f1e17a74cec933b3
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/5.1)

Reviewed: https://review.openstack.org/135028
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=9c5148236af6b458ddd64eec1df4634897e3f6f4
Submitter: Jenkins
Branch: stable/5.1

commit 9c5148236af6b458ddd64eec1df4634897e3f6f4
Author: Bogdan Dobrelya <email address hidden>
Date: Mon Nov 17 18:32:54 2014 +0100

    Fix comments in logrotation templates

    W/o this fix, some log files at Openstack nodes cannot be rotated at the
    hourly schedule and /var/log could end up having no free space while
    waiting for the next daily based rotation schedule.

    Closes-bug: #1393495

    Change-Id: I192ebbd31f83fb264307c1c2f1e17a74cec933b3
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Bogdan Dobrelya (bogdando)
summary: - Typo in logrotate template cause issue with hourly rotations at nodes
+ Typo in logrotate template causes issue with hourly rotations at nodes
Revision history for this message
Vadim Rovachev (vrovachev) wrote :

Verified on:
{"build_id": "2014-11-20_21-01-00", "ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346", "build_number": "28", "auth_required": true, "api": "1.0", "nailgun_sha": "7580f6341a726c2019f880ae23ff3f1c581fd850", "production": "docker", "fuelmain_sha": "eac9e2704424d1cb3f183c9f74567fd42a1fa6f3", "astute_sha": "51087c92a50be982071a074ff2bea01f1a5ddb76", "feature_groups": ["mirantis"], "release": "5.1.1", "release_versions": {"2014.1.3-5.1.1": {"VERSION": {"build_id": "2014-11-20_21-01-00", "ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346", "build_number": "28", "api": "1.0", "nailgun_sha": "7580f6341a726c2019f880ae23ff3f1c581fd850", "production": "docker", "fuelmain_sha": "eac9e2704424d1cb3f183c9f74567fd42a1fa6f3", "astute_sha": "51087c92a50be982071a074ff2bea01f1a5ddb76", "feature_groups": ["mirantis"], "release": "5.1.1", "fuellib_sha": "b3d9f0e203f2f0faf3763e871a8dc31570777fed"}}}, "fuellib_sha": "b3d9f0e203f2f0faf3763e871a8dc31570777fed"}

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (stable/5.0)

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: stable/5.0
Review: https://review.openstack.org/135027

Revision history for this message
Alexey Stupnikov (astupnikov) wrote :

MOS5.0 is no longer supported, moving to Won't Fix.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.