Unsafe kill in OpenStack init scripts

Bug #1362839 reported by Dmitry Borodaenko
38
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Won't Fix
High
Sergey Vasilenko
5.0.x
Won't Fix
High
Sergey Vasilenko

Bug Description

As found in bug #1355758, using constructs like killall to stop a service during restart is not safe and should be avoided. We need to review all our init scripts and eliminate unsafe kill operations.

Revision history for this message
Ryan Moe (rmoe) wrote :

In CentOS the following init scripts have potentially unsafe killall calls:

neutron-dhcp-agent
neutron-l3-agent
neutron-lbaas-agent
neutron-metadata-agent
neutron-openvswitch-agent
openstack-cinder-api
openstack-cinder-backup
openstack-cinder-scheduler
openstack-cinder-volume
openstack-glance-api
openstack-glance-registry
openstack-glance-scrubber
openstack-heat-api
openstack-heat-api-cfn
openstack-heat-api-cloudwatch
openstack-heat-engine
openstack-keystone
openstack-nova-api
openstack-nova-cert
openstack-nova-conductor
openstack-nova-console
openstack-nova-consoleauth
openstack-nova-metadata-api
openstack-nova-novncproxy
openstack-nova-objectstore
openstack-nova-scheduler
openstack-nova-spicehtml5proxy
openstack-nova-xvpvncproxy

Changed in fuel:
status: New → Confirmed
Revision history for this message
Mike Scherbakov (mihgen) wrote :

Are we affected by this at the moment? I mean, is it a show stopper for 5.1 release? What are the conditions under which we would be affected by this?

Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Sergey Vasilenko (xenolog)
status: Confirmed → In Progress
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package neutron has been built from changeset: http://gerrit.mirantis.com/21310
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21310/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package neutron has been built from changeset: http://gerrit.mirantis.com/21310
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21310/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21465
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.0.2-stable-21465/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

Package murano-api has been built from changeset: http://gerrit.mirantis.com/21466
RPM Repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-5.1-stable-21466/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Revision history for this message
OSCI Robot (oscirobot) wrote :
Changed in fuel:
milestone: 5.1 → 5.1.1
Revision history for this message
Dmitry Mescheryakov (dmitrymex) wrote :

The issue is not yet merged actually

Revision history for this message
Vladimir Kuklin (vkuklin) wrote :

since we fixed underlying openstack and python components - these fixes are no longer needed both for 5.1.1 and 6.0 releases

Changed in fuel:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.