NSX plugin: deployment fails because of wrong service_plugins line in neutron config

Build version: {"build_id": "2014-08-27_10-46-57", "ostf_sha": "4dcd99cc4bfa19f52d4b87ed321eb84ff03844da", "build_number": "481", "auth_required": true, "api": "1.0", "nailgun_sha": "04e3f9d9ad3140cd63a9b5a1a302c03ebe64fd0a", "production": "docker", "fuelmain_sha": "74a97d500bb2fe9528f99771ccc2ec657ae3f76e", "astute_sha": "bc60b7d027ab244039f48c505ac52ab8eb0a990c", "feature_groups": ["mirantis"], "release": "5.1", "fuellib_sha": "6f478caa9111e428b3c053eef44754f59ce7a2c2"}

Deployment of controller with NSX plugin installation because of wrong Neutron config:

 (/Stage[main]/Neutron::Server/Exec[neutron-db-sync]) neutron-db-manage --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head returned 1 instead of one of [0]

No handlers could be found for logger "neutron.common.legacy"
Traceback (most recent call last):
  File "/usr/bin/neutron-db-manage", line 10, in <module>
    sys.exit(main())
  File "/usr/lib/python2.6/site-packages/neutron/db/migration/cli.py", line 169, in main
    CONF.command.func(config, CONF.command.name)
  File "/usr/lib/python2.6/site-packages/neutron/db/migration/cli.py", line 82, in do_upgrade_downgrade
    do_alembic_command(config, cmd, revision, sql=CONF.command.sql)
  File "/usr/lib/python2.6/site-packages/neutron/db/migration/cli.py", line 60, in do_alembic_command
    getattr(alembic_command, cmd)(config, *args, **kwargs)
  File "/usr/lib/python2.6/site-packages/alembic/command.py", line 124, in upgrade
    script.run_env()
  File "/usr/lib/python2.6/site-packages/alembic/script.py", line 199, in run_env
    util.load_python_file(self.dir, 'env.py')
  File "/usr/lib/python2.6/site-packages/alembic/util.py", line 199, in load_python_file
    module = load_module(module_id, path)
  File "/usr/lib/python2.6/site-packages/alembic/compat.py", line 55, in load_module
    mod = imp.load_source(module_id, path, fp)
  File "/usr/lib/python2.6/site-packages/neutron/db/migration/alembic_migrations/env.py", line 42, in <module>
    importutils.import_class(class_path)
  File "/usr/lib/python2.6/site-packages/neutron/openstack/common/importutils.py", line 33, in import_class
    traceback.format_exception(*sys.exc_info())))
ImportError: Class cannot be found (['Traceback (most recent call last):\n', ' File "/usr/lib/python2.6/site-packages/neutron/openstack/common/importutils.py", line 28, in import_class\n __import__(mod_str)\n', 'ValueError: Empty module name\n']

I presume that error caused by line 'service_plugins =' in neutron.conf.

Currently that line is created by code in deployment/puppet/neutron/lib/puppet/parser/functions/sanitize_neutron_config.rb:

"# TODO (adanin) Service plugins should be like below but don't work. 467
   #@neutron_config[:server][:service_plugins] = 'neutron.plugins.vmware.plugin.NsxServicePlugin'

   @neutron_config[:server][:service_plugins] = ' '

Proposed fix: As stated in http://docs.openstack.org/admin-guide-cloud/content/LBaaS_and_FWaaS.html

"To configure Load-Balancer-as-a-Service and Firewall-as-a-Service with NSX

Edit the /etc/neutron/neutron.conf file:

core_plugin = neutron.plugins.vmware.plugin.NsxServicePlugin
# Note: comment out service_plug-ins. LBaaS & FWaaS is supported by core_plugin NsxServicePlugin
# service_plugins ="

so I propose don't create service_plugins parameter at all.