[update] OpenStack Patching : puppet's versioncmp behaves wrong

Actually it's not really a versioncmp bug.

Puppet::Util::Package.versioncmp('2014.1.fuel5.0-mira4', '2014.1.1.fuel5.1-mira0')
=> 1

But first is lower then second and it should be -1

["2014", ".", "1", ".", "fuel", "5", ".", "0", "-", "mira", "4"]
["2014", ".", "1", ".", "1", ".", "fuel", "5", ".", "1", "-", "mira", "0"]
2014 vs 2014
. vs .
1 vs 1
. vs .
fuel vs 1
1

See? there are two 1's instead of one in the newer version. But it should be like this:
["2014", ".", "1", ".", "fuel", "5", ".", "0", "-", "mira", "4"]
["2014", ".", "1", ".", "fuel", "5", ".", "1", "-", "mira", "0"]
2014 vs 2014
. vs .
1 vs 1
. vs .
fuel vs fuel
5 vs 5
. vs .
0 vs 1
-1

So we should just rename package from 2014.1.1.fuel5.1-mira0 to 2014.1.fuel5.1-mira0

Ok, but the issue isn't invalid. How to fix that - another question. But it still presence and we need to fix it in order to deliver openstack patching.

Fix proposed to branch: master
Review: https://review.openstack.org/106997

Note that the patch implies hardcoded separation between MOS <-> Fuel versioning patterns based on the 'fuel' separator. Omitting that one would be destructive.

If we wanted rollback to 5.0.1 feature be possible, we would have wanted this as 5.0.1 backport as well.

Latest comment in the linked review:

"It does help with CentOS but doesn't help with Ubuntu.

I guess we need to fix this on the package level."

indicates that this is a packaging problem.

Related bug https://bugs.launchpad.net/fuel/+bug/1342716

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/106997

Fix proposed to branch: stable/5.0
Review: https://review.openstack.org/111010

Reviewed: https://review.openstack.org/106997
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=004ab7ed0e6e4268f3657d47836d3629f339bd9a
Submitter: Jenkins
Branch: master

commit 004ab7ed0e6e4268f3657d47836d3629f339bd9a
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Jul 15 14:08:46 2014 +0300

    Compare Fuel versions as well as MOS ones

    * Add rspec test cases for tricky and usual version formats, e.g.
      tricky: '2014.1.fuel5.0-mira4' vs '2014.1.1.fuel5.1-mira0'
      usual: '2014.1.fuel5.0-mira4' vs '2014.1.fuel5.1-mira0'
      (both for downgrading and installing cases)
    * Make a yum downgrade decision based BOTH onto MOS versions and
      Fuel versions comparsion results instead of full MOSt versions
      ('fuel' hardcoded as a separator for MOS and Fuel versions in MOSt)

    Closes-bug: #1342041

    Change-Id: Icacec5ed01510ab526a4b0e6092efdf203a6a2cb
    Signed-off-by: Bogdan Dobrelya <email address hidden>

FIxed in this commit https://review.openstack.org/#/c/112910/

Move in proggress ащк 5.0.x according review is not merged yet

Reviewed: https://review.openstack.org/111010
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=50ac798300f305db6c64a4bb8007fff25656826f
Submitter: Jenkins
Branch: stable/5.0

commit 50ac798300f305db6c64a4bb8007fff25656826f
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Jul 15 14:08:46 2014 +0300

    Compare Fuel versions as well as MOS ones

    * Add rspec test cases for tricky and usual version formats, e.g.
      tricky: '2014.1.fuel5.0-mira4' vs '2014.1.1.fuel5.1-mira0'
      usual: '2014.1.fuel5.0-mira4' vs '2014.1.fuel5.1-mira0'
      (both for downgrading and installing cases)
    * Make a yum downgrade decision based BOTH onto MOS versions and
      Fuel versions comparsion results instead of full MOSt versions
      ('fuel' hardcoded as a separator for MOS and Fuel versions in MOSt)

    Closes-bug: #1342041

    Change-Id: Icacec5ed01510ab526a4b0e6092efdf203a6a2cb
    Signed-off-by: Bogdan Dobrelya <email address hidden>