Fuel for OpenStack

iso build should fail when docker build fails

Bug #1337288 reported by Matthew Mosesohn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Matthew Mosesohn
Fuel for OpenStack 5.1

Bug Description

If puppet apply returns nonzero, we should cancel the ISO build and mark it a failure.

Refer to gerrit docker iso 296 as an example.

Tags: iso
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/107039

Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/107284

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/107039
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=95f1a60a5a2cc987edd4a257fd875355d64a25f9
Submitter: Jenkins
Branch: master

commit 95f1a60a5a2cc987edd4a257fd875355d64a25f9
Author: Matthew Mosesohn <email address hidden>
Date: Tue Jul 15 16:55:47 2014 +0400

    Fail docker build if puppet fails

    Puppet does not return non-zero exit code if
    there are errors during deployment.

    FIXME: Cobbler has iptables bugs. Implement at future date.

    Change-Id: I86834cb62beac981e8c3defb8b2d90bafafb84b6
    Closes-Bug: #1337288

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/107284
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=e91c20221ee687066e058664162430b4131c8f62
Submitter: Jenkins
Branch: master

commit e91c20221ee687066e058664162430b4131c8f62
Author: Matthew Mosesohn <email address hidden>
Date: Wed Jul 16 13:42:59 2014 +0400

    Cobbler docker mode fixes

    Skip cobbler::iptables in docker container for
    all docker modes and don't create profiles and
    distros during docker build.

    IPtables cannot be modified inside a Docker
    container. It creates errors that interfere
    with deployment.

    Change-Id: I9c3f54f3c0fd2afdcb425d37a3daecfa3c0173af
    Closes-Bug: #1342075
    Related-Bug: #1337288

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.