Fuel for OpenStack

[mos] openvswitch agent fails with bridges longer than 11 chars

Bug #1328288 reported by Kevin Benton
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
MOS Neutron
Fuel for OpenStack 5.1
5.0.x
Won't Fix
High
MOS Neutron
Fuel for OpenStack 5.0.2
neutron
Fix Released
Medium
Kevin Benton
neutron 2014.2 "juno"
Icehouse
Fix Released
Undecided
Unassigned
neutron 2014.1.2

Bug Description

The openvswitch agent will try to construct veth pairs with names longer than the maximum allowed (15) and fail. VMs will then have no external connectivity.

This happens in cases where the bridge name is very long (e.g. int-br-bonded).

Kevin Benton (kevinbenton)
tags: added: icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/98911

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Revision history for this message
Kevin Benton (kevinbenton) wrote : Re: openvswitch agent fails with bridges longer than 11 chars

Here is an example:

$ ip link add int-int-br-bonded type veth peer name phy-int-br-bonded
Error: argument "peer" is wrong: "name" too long

Kyle Mestery (mestery)
tags: added: ovs
Changed in neutron:
importance: Undecided → Medium
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/98911
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1222366f6dadf7ce2a810c919344054196134db8
Submitter: Jenkins
Branch: master

commit 1222366f6dadf7ce2a810c919344054196134db8
Author: Kevin Benton <email address hidden>
Date: Fri Jun 6 08:15:38 2014 -0700

    OVS Agent: limit veth names to 15 chars

    The maximum length of a veth interface name is 15 characters.
    This patch limits the length of the veth names created for
    integration bridges by switching to a fixed-length hashing
    mechanism if the normal name would exceed the allowed length.

    Closes-Bug: #1328288
    Change-Id: I432cee62a6dc91f268becbc91f8024c23dd0bfac

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/99273

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/99273
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ca7ed8f84da6962a9c2b8ad21d484931d297f31b
Submitter: Jenkins
Branch: stable/icehouse

commit ca7ed8f84da6962a9c2b8ad21d484931d297f31b
Author: Kevin Benton <email address hidden>
Date: Fri Jun 6 08:15:38 2014 -0700

    OVS Agent: limit veth names to 15 chars

    The maximum length of a veth interface name is 15 characters.
    This patch limits the length of the veth names created for
    integration bridges by switching to a fixed-length hashing
    mechanism if the normal name would exceed the allowed length.

    Closes-Bug: #1328288
    Change-Id: I432cee62a6dc91f268becbc91f8024c23dd0bfac
    (cherry-picked from 1222366f6dadf7ce2a810c919344054196134db8)

tags: added: in-stable-icehouse
Andrew Woodward (xarses)
Changed in fuel:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Fuel OSCI Team (fuel-osci)
milestone: none → 5.1
Vitaly Parakhin (vparakhin)
Changed in fuel:
assignee: Fuel OSCI Team (fuel-osci) → Fuel Hardening Team (fuel-hardening)
Ilya Shakhat (shakhat)
Changed in fuel:
assignee: Fuel Hardening Team (fuel-hardening) → MOS Neutron (mos-neutron)
Revision history for this message
Vladimir Kuklin (vkuklin) wrote : Re: openvswitch agent fails with bridges longer than 11 chars

I am not sure that this bug affects Mirantis OpenStack distribution as we are using OVS 1.10 which creates patch interfaces in userspace, thus avoiding intereference with kernel limits. We need to recheck if it reproduces on MOS environments.

Changed in fuel:
status: Confirmed → Incomplete
Revision history for this message
Kevin Benton (kevinbenton) wrote :

The openvswitch agent for Neutron Icehouse doesn't leverage patch interfaces.

I have already fixed this on the Neutron side and back-ported to Icehouse[1] so I'm not sure it needs to be high-priority (assuming Fuel grabs the Icehouse updates). This is especially true because we were doing a non-standard deployment by skipping the br-priv bridge that is normally used between the physical interface bridge and br-int. i.e. it was only a problem when the ovs agent was configured to patch directly to the br0--ovs-bond0 bridge for one of the physnets.

1. https://github.com/openstack/neutron/commit/ca7ed8f84da6962a9c2b8ad21d484931d297f31b

Vladimir Kuklin (vkuklin)
Changed in fuel:
importance: Medium → High
Vladimir Kuklin (vkuklin)
Changed in fuel:
status: Incomplete → Confirmed
Dmitry Ilyin (idv1985)
summary: - openvswitch agent fails with bridges longer than 11 chars
+ [mos] openvswitch agent fails with bridges longer than 11 chars
Eugene Nikanorov (enikanorov)
summary: - [mos] openvswitch agent fails with bridges longer than 11 chars
+ openvswitch agent fails with bridges longer than 11 chars
Dmitry Ilyin (idv1985)
summary: - openvswitch agent fails with bridges longer than 11 chars
+ [mos] openvswitch agent fails with bridges longer than 11 chars
Revision history for this message
Andrey Epifanov (aepifanov) wrote :

Fix committed as a part of merge with stable/icehouse branch:
https://bugs.launchpad.net/mos/+bug/1344037

Changed in fuel:
status: Confirmed → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.