[nailgun] Instances created with wrong IP range on second cluster

Bug #1323965 reported by Nicholas Chase
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Aleksey Kasatkin

Bug Description

I have today's 5.0 ISO of fuel, and created two clusters, each in Multi-Node (non-HA) with one controller and one compute.

Both use FlatDHCPManager, but I changed the IP ranges so they don't conflict. Specifically, in cluster1, under Nova network configuration, the Fixed Network CIDR is set to 10.0.0.0/16, while in cluster2 it's set to 10.0.3.0/16.

When I create a VM in cluster1 (though Horizon) it comes out with an IP of 10.0.0.2, as expected. However, when I create one in cluster2 (also through Horizon) it ALSO comes up as 10.0.0.2.

Revision history for this message
Sergii Golovatiuk (sgolovatiuk) wrote :

The problem is in mask you used. It overlaps the range from first and second cluster. /16 means 10.0.X.X thus you had a problem. Please use /24 instead. If you still want /16 please use second octet as distinguishing attribute. 10.0.0.0/16 and 10.X.0.0/16 should work fine.

Changed in fuel:
status: New → Invalid
Revision history for this message
Andrew Woodward (xarses) wrote :

No, I agree that this is a bug, they are both the same CIDR network and should have been assigning from the same network in the DB.

We either need to validate the network address and reject address that don't match the expected host address (10.0.0.0/16) or we need to do the translation in the DB.

In this case it should have assigned
10.0.0.2 - cluster 1
10.0.0.3 - cluster 2

OR raised an error when 10.0.3.0/16 was inserted as it is a host address, not a network address.

Changed in fuel:
status: Invalid → Confirmed
importance: Undecided → Medium
assignee: nobody → Fuel Python Team (fuel-python)
milestone: none → 5.1
Dmitry Ilyin (idv1985)
summary: - Instances created with wrong IP range on second cluster
+ [nailgun] Instances created with wrong IP range on second cluster
Revision history for this message
Mike Scherbakov (mihgen) wrote :

> raised an error when 10.0.3.0/16 was inserted as it is a host address, not a network address.
we should do this validation I think.

Dima Shulyak (dshulyak)
tags: added: nailgun-networking
Kamil Sambor (ksambor)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Kamil Sambor (ksambor)
Changed in fuel:
assignee: Kamil Sambor (ksambor) → Aleksey Kasatkin (alekseyk-ru)
status: Confirmed → In Progress
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

CIDR must be validated in both Nailgun and UI.

Changed in fuel:
status: In Progress → Confirmed
assignee: Aleksey Kasatkin (alekseyk-ru) → Fuel Python Team (fuel-python)
tags: added: nailgun
removed: nailgun-networking
Changed in fuel:
milestone: 5.1 → 6.0
Changed in fuel:
milestone: 6.0 → 6.1
Dmitry Pyzhov (dpyzhov)
tags: added: feature
Dmitry Pyzhov (dpyzhov)
tags: added: module-networks
removed: nailgun
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Aleksey Kasatkin (alekseyk-ru)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/170901

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/170901
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=2502e205f1974d82187edcd68fb79fd250d3209c
Submitter: Jenkins
Branch: master

commit 2502e205f1974d82187edcd68fb79fd250d3209c
Author: Aleksey Kasatkin <email address hidden>
Date: Mon Apr 6 18:47:39 2015 +0300

    Check calculated network CIDR is equal to user-defined value

    This helps to avoid problem described in ticket and in general
    to avoid some user errors when entering networks parameters.

    Change-Id: Iabb36ef7bc00021fad29cfd7417bd7846144b5ac
    Related-Bug: #1323965

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

CIDR check is added for 6.1. Let's consider further possible changes in 7.0.

Changed in fuel:
milestone: 6.1 → 7.0
assignee: Aleksey Kasatkin (alekseyk-ru) → Fuel Python Team (fuel-python)
Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/7.0.x
no longer affects: fuel/6.1.x
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.