[neutron] OSTF provides wrong failure message for ping probes

Bug #1323433 reported by Mike Scherbakov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
Medium
Artem Roma
5.0.x
Won't Fix
Medium
Fuel Python (Deprecated)

Bug Description

This looks like a regression caused by https://review.openstack.org/#/c/95153/2.
My suggestion is to immediately revert the change, and release without this patch.

Symptoms:
many system tests are failed with
'Check network connectivity from instance via floating IP': u'Command execution failed. Please refer to OpenStack logs for more details.'

For the end user, it is even worse that false positive result saying that everything is Ok while it is not, because it points out to an error in OpenStack ('Please refer to OpenStack logs for more details') while the issue is in OSTF.

Tags: module-ostf
Revision history for this message
Mike Scherbakov (mihgen) wrote :
Revision history for this message
Mike Scherbakov (mihgen) wrote :

5.0 should be fixed by revert: https://review.openstack.org/#/c/95606/, so closing issue for 5.0.
master branch is still affected.

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

It is to be checked whether master branch is affected or not. Patch in master branch have smaller changes.

Revision history for this message
Tatyanka (tatyana-leontovich) wrote :

There were not retries att all - one attemp - and then test failed

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

ISO 5.0-26: It seems that problem was not solved with revert.

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :
Download full text (3.5 KiB)

From OSTF log:

ERROR (nose_storage_plugin) fuel_health.tests.smoke.test_nova_create_instance_with_connectivity.TestNovaNetwork.test_004_create_servers
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/unittest2/case.py", line 340, in run
    testMethod()
  File "/usr/lib/python2.6/site-packages/fuel_health/tests/smoke/test_nova_create_instance_with_connectivity.py", line 169, in test_004_create_servers
    self.compute_client, name, security_groups
  File "/usr/lib/python2.6/site-packages/fuel_health/common/test_mixins.py", line 192, in verify
    " Please refer to OpenStack logs for more details.")
  File "/usr/lib/python2.6/site-packages/unittest2/case.py", line 415, in fail
    raise self.failureException(msg)
AssertionError: Step 2 failed: Failed to get to expected status. In error state. Please refer to OpenStack logs for more details.
-------------------- >> begin captured logging << --------------------
urllib3.connectionpool: INFO: Starting new HTTP connection (1): 10.20.0.4
urllib3.connectionpool: DEBUG: "GET http://172.16.0.2:8774/v2/c6c9ad847554444695c4c05199c7494d/images/detail HTTP/1.1" 200 1570
fuel_health.nmanager: DEBUG: [<Image: TestVM>, <Image: TestVM>]
fuel_health.nmanager: DEBUG: TestVM
fuel_health.nmanager: DEBUG: TestVM
urllib3.connectionpool: INFO: Starting new HTTP connection (1): 10.20.0.4
urllib3.connectionpool: DEBUG: "GET http://172.16.0.2:8774/v2/c6c9ad847554444695c4c05199c7494d/images/detail HTTP/1.1" 200 1570
fuel_health.nmanager: DEBUG: [<Image: TestVM>, <Image: TestVM>]
fuel_health.nmanager: DEBUG: TestVM
fuel_health.nmanager: DEBUG: TestVM
urllib3.connectionpool: INFO: Starting new HTTP connection (1): 10.20.0.4
urllib3.connectionpool: DEBUG: "GET http://172.16.0.2:8774/v2/c6c9ad847554444695c4c05199c7494d/os-networks HTTP/1.1" 200 1142
urllib3.connectionpool: INFO: Starting new HTTP connection (1): 10.20.0.4
urllib3.connectionpool: DEBUG: "POST http://172.16.0.2:8774/v2/c6c9ad847554444695c4c05199c7494d/servers HTTP/1.1" 202 467
urllib3.connectionpool: INFO: Starting new HTTP connection (1): 10.20.0.4
urllib3.connectionpool: DEBUG: "GET http://172.16.0.2:8774/v2/c6c9ad847554444695c4c05199c7494d/servers/4270842c-65d5-4fa5-81d1-31d079772a55 HTTP/1.1" 200 1448
fuel_health.test: DEBUG: Adding <Server: ost1_test-server-smoke-25087196> to shared resources of TestNovaNetwork
fuel_health.config: INFO: INSTANCE {409: <fuel_health.config.NailgunConfig object at 0x4172790>}
urllib3.connectionpool: INFO: Starting new HTTP connection (1): 10.20.0.4
urllib3.connectionpool: DEBUG: "GET http://172.16.0.2:8774/v2/c6c9ad847554444695c4c05199c7494d/servers/4270842c-65d5-4fa5-81d1-31d079772a55 HTTP/1.1" 200 1698
fuel_health.common.test_mixins: DEBUG: Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/fuel_health/common/test_mixins.py", line 186, in verify
    result = func(*args, **kwargs)
  File "/usr/lib/python2.6/site-packages/fuel_health/nmanager.py", line 502, in _create_server
    self.status_timeout(client.servers, server.id, 'ACTIVE')
  File "/usr/lib/python2.6/site-packages/fuel_health/test.py", line 128, in status_timeout
    conf.compute.build_interval):
  File "/usr/l...

Read more...

Revision history for this message
Tatyanka (tatyana-leontovich) wrote :

Aleksey you should sync time on each node and restart nova services and try one more time

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

Number of probes is Ok (equal to 6) but error message is the same: "Command execution failed. Please refer to OpenStack logs for more details." AFAIC, it was the same before that PR.

Revision history for this message
Tatyanka (tatyana-leontovich) wrote :

aggreed, but in attached logs retries missed. There was only one probe - that return exit status 1 and. It is incorrect behavior. As about message - we show such message every time, may be we shoul provide message something like operation A was not success in timeout B

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

Logs from 5.0-26.

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

Changes in https://review.openstack.org/#/c/95153/2 doesn't cause to change of error message. It was the same before that request is merged. Message propagation logic must be changed to provide the ability of exposing original error message to user via OSTF API.

Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/5.1.x
Changed in fuel:
milestone: 5.0 → 5.1
status: Fix Committed → Triaged
importance: Critical → Medium
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
status: Triaged → Confirmed
Dmitry Ilyin (idv1985)
summary: - OSTF provides wrong failure message for ping probes
+ [neutron] OSTF provides wrong failure message for ping probes
Changed in fuel:
milestone: 5.1 → 6.0
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 6.0 → 6.1
Dmitry Pyzhov (dpyzhov)
tags: added: module-ostf
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Artem Roma (aroma-x)
Revision history for this message
Artem Roma (aroma-x) wrote :

Ok, there is no significant activity for this bug for almost a year now and as I may assume from comments in activity log the problem related mostly to how we propagate error messages inside tests' infrastructure, not to the changes in committed PR (as given in description). Lets close this bug as invalid and create new one related more to the roots of the observed issue (incorrect error message).

Changed in fuel:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.