Fuel for OpenStack

Checking order of locked tables

Bug #1319668 reported by Alexander Kislitsky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Alexander Kislitsky
Fuel for OpenStack 5.1

Bug Description

For deadlocks prevention we should not only select objects in the same order, but also check the order of tables lock.
Possible lock transitions should be defined and fixed in the logic of deadlock detector.

Tags: nailgun
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/93678

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Alexander Kislitsky (akislitsky) wrote :

This bug is part deadlocks detection issue and related to bug #1308115

Revision history for this message
Mike Scherbakov (mihgen) wrote :

Moving this to 5.1. If it affects 5.0 tests further, then we will backport patch to stable/5.0.

Changed in fuel:
milestone: 5.0 → 5.1
Revision history for this message
Evgeniy L (rustyrobot) wrote :

We still have this problem

http://paste.openstack.org/show/85083/
http://paste.openstack.org/show/85084/
https://fuel-jenkins.mirantis.com/job/verify-fuel-web/81/consoleFull
https://fuel-jenkins.mirantis.com/job/verify-fuel-web/84/consoleFull

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/93678
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=9e98e0bbb001724ee38f18320991b0145ebc6a15
Submitter: Jenkins
Branch: master

commit 9e98e0bbb001724ee38f18320991b0145ebc6a15
Author: Alexander Kislitsky <email address hidden>
Date: Thu May 15 11:22:29 2014 +0400

    Checking the tables order when rows are locking

    Deadlock detector checks the order of locked tables. In case of
    not allowed locking order exception with locks and traceback
    information is raised. Detection enabled only in DEVELOPMENT
    mode. Deadlock detector only prevents the posibility of deadlocks

    Change-Id: I4097aa2ad8942bf852d0e89054e13500fbfc6646
    Closes-Bug: #1319668

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.