[nailgun] dump.log has to be renamed to shotgun.log

Bug #1318516 reported by Mike Scherbakov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Ivan Kliuk

Bug Description

When I see running of shotgun utility from astute.log, I assume that there is going to be logging for shotgun, and my assumption is based on experience with other components of Fuel - so I’m looking for shotgun.log or shotgun/*.log (shotgun folder with log files). Neither was found. After I’ve spent additional time, I was able to identify where the log is, and it appeared to be completely different name - dump.log. Let’s rename it to avoid such useless cycles spent on troubleshooting and support.

With current implementation of diagnostic snapshot, it will require to change log name in settings, see example at https://review.openstack.org/#/c/93178/

Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Shotgun prints logs to standard output, not a file.
Dump.log is created by redirecting stdout to file by fuel-astute ( https://github.com/stackforge/fuel-astute/blob/master/lib/astute/dump.rb#L32 )

Should we fix it in fuel-astute? Or we need to implement file logging in shotgun?

Changed in fuel:
importance: Undecided → Low
milestone: none → 5.1
status: New → Confirmed
Dmitry Ilyin (idv1985)
summary: - dump.log has to be renamed to shotgun.log
+ [nailgun] dump.log has to be renamed to shotgun.log
Changed in fuel:
milestone: 5.1 → 6.0
Ivan Kliuk (ivankliuk)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Ivan Kliuk (ivankliuk)
Ivan Kliuk (ivankliuk)
Changed in fuel:
milestone: 6.0 → 6.1
Ivan Kliuk (ivankliuk)
Changed in fuel:
assignee: Ivan Kliuk (ivankliuk) → Fuel Python Team (fuel-python)
Evgeniy L (rustyrobot)
tags: added: s-size
Dmitry Pyzhov (dpyzhov)
tags: added: module-shotgun
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Ivan Kliuk (ivankliuk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/170805

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-astute (master)

Fix proposed to branch: master
Review: https://review.openstack.org/170810

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/170805
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=4b5678fd43601ec0ccac4459b6fe34ccb5d48535
Submitter: Jenkins
Branch: master

commit 4b5678fd43601ec0ccac4459b6fe34ccb5d48535
Author: Ivan Kliuk <email address hidden>
Date: Sat Apr 4 19:27:24 2015 +0300

    Add a file handler for shotgun's logger

      Add LOG_FILE variable to shotgun.settings.
      Add FileHandler in logging.py module.

    Change-Id: I8fec28baddc26c18a9b2821fe5b398aa016cdbef
    Closes-Bug: 1318516

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-astute (master)

Reviewed: https://review.openstack.org/170810
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=cb1af603c63646a17da6aafbee1ef437eba5256f
Submitter: Jenkins
Branch: master

commit cb1af603c63646a17da6aafbee1ef437eba5256f
Author: Ivan Kliuk <email address hidden>
Date: Sat Apr 4 19:35:17 2015 +0300

    Remove redirection from stdout to dump.log

      Since FileHandler is added to shotgun's logger, there's no need in
      redirection to stdout.

    Related to change: https://review.openstack.org/#/c/170805
    Closes-Bug: 1318516

    Change-Id: Ibc06dab96c8595163ece003402735c7a33ecefd0

Revision history for this message
Alexander Bozhenko (alexbozhenko) wrote :

Please change dump.log to shotgun.log in logrotate configuration.

Changed in fuel:
status: Fix Committed → Confirmed
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

I've created a new bug report for new issue: https://bugs.launchpad.net/fuel/+bug/1446790

Changed in fuel:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.