OpenStack Backup/Restore and DR (Freezer)

Class QueuedThread does not proopagate exceptions to caller

  1. Series mitaka
  2. Bug #1592589
Bug #1592589 reported by Deklan Dieterly
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Backup/Restore and DR (Freezer)
Fix Released
Undecided
Deklan Dieterly
OpenStack Backup/Restore and DR (Freezer) newton-2 "n2"
Mitaka
Fix Committed
Undecided
Unassigned

Bug Description

Class QueuedThread does not log or pass exceptions up to caller. This makes exceptions in threads invisible.

Revision history for this message
Deklan Dieterly (deklan) wrote :

This code in QueuedThread will not do anything when an exception is caught. Raising an exception from a thread will not propagate to the caller. The exception will be lost.

    def run(self):
        try:
            super(QueuedThread, self).run()
        except Exception as e:
            self.rich_queue.force_stop()
            raise e

Deklan Dieterly (deklan)
Changed in freezer:
status: New → In Progress
assignee: nobody → Deklan Dieterly (deklan)
Revision history for this message
Deklan Dieterly (deklan) wrote :

Subprocesses also do not propagate exceptions correctly.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to freezer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/330787

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to freezer (master)

Reviewed: https://review.openstack.org/330787
Committed: https://git.openstack.org/cgit/openstack/freezer/commit/?id=3cdfd8fba361d76ea7f65652f740ae80eab6d7c5
Submitter: Jenkins
Branch: master

commit 3cdfd8fba361d76ea7f65652f740ae80eab6d7c5
Author: Deklan Dieterly <email address hidden>
Date: Thu Jun 16 15:00:25 2016 -0600

    Fix exception propagation

    Make exception propagation from subprocesses and
    threads work correctly.
    Make exceptions propagate to top level program.
    Make exceptions in subprocesses and threads log correctly.
    Fix Tempest README.rst

    Change-Id: If9ebe36afdc02c2460a86da7b4d9fa15e12c5824
    Closes-Bug: #1592589

Changed in freezer:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to freezer (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/337590

Pierre-Arthur MATHIEU (pi3rra)
Changed in freezer:
milestone: none → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to freezer (stable/mitaka)

Reviewed: https://review.openstack.org/337590
Committed: https://git.openstack.org/cgit/openstack/freezer/commit/?id=a34980ecc70d926bb2c91baa743b18ee73d9a241
Submitter: Jenkins
Branch: stable/mitaka

commit a34980ecc70d926bb2c91baa743b18ee73d9a241
Author: Deklan Dieterly <email address hidden>
Date: Thu Jun 16 15:00:25 2016 -0600

    Fix exception propagation

    Make exception propagation from subprocesses and
    threads work correctly.
    Make exceptions propagate to top level program.
    Make exceptions in subprocesses and threads log correctly.
    Fix Tempest README.rst

    Conflicts:
     freezer/engine/engine.py
     freezer/engine/tar/tar_engine.py
     freezer/tests/freezer_tempest_plugin/README.rst
     freezer/utils/streaming.py

    Closes-Bug: #1592589

    (cherry picked from commit 3cdfd8fba361d76ea7f65652f740ae80eab6d7c5)

    Change-Id: If9ebe36afdc02c2460a86da7b4d9fa15e12c5824

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/freezer 3.0.0.0b2

This issue was fixed in the openstack/freezer 3.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.