freezer-web-ui

Strings in django templates are not extracted properly for translation

Bug #1747453 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Blazar
Fix Released
Undecided
Akihiro Motoki
Neutron FWaaS dashboard
Fix Released
Undecided
Akihiro Motoki
Neutron VPNaaS dashboard
Fix Released
High
Akihiro Motoki
freezer-web-ui
Fix Released
Undecided
Akihiro Motoki
heat-dashboard
Fix Released
Undecided
Akihiro Motoki
manila-ui
Fix Released
Undecided
Akihiro Motoki
networking-bgpvpn
Fix Released
Undecided
Akihiro Motoki

Bug Description

From the reason described in https://storyboard.openstack.org/#!/story/2001514, strings in django templates are not extracted properly.
As a result, strings from Django templates cannot be translated.

This seems caused by incorrectness in the infra manual "Project Creators Guide".

See original description
Tags: i18n
Akihiro Motoki (amotoki)
tags: added: i18n
Revision history for this message
Akihiro Motoki (amotoki) wrote :

I added the affected projects under OpenStack TC governances.

There are other project whose babel-django.cfg contains "[django: templates/**.html]", but they have only AngularJS-based implementations and they are actually not affected. It might be nice to fix "[django: templates/**.html]" in these files but it is optional. This bug is intended to track the actual problem.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/540907

Changed in neutron-fwaas-dashboard:
assignee: nobody → Akihiro Motoki (amotoki)
status: New → In Progress
Akihiro Motoki (amotoki)
Changed in neutron-vpnaas-dashboard:
assignee: nobody → Akihiro Motoki (amotoki)
Changed in freezer-web-ui:
assignee: nobody → Akihiro Motoki (amotoki)
Changed in heat-dashboard:
assignee: nobody → Akihiro Motoki (amotoki)
Changed in manila-ui:
assignee: nobody → Akihiro Motoki (amotoki)
Changed in blazar:
assignee: nobody → Akihiro Motoki (amotoki)
Changed in bgpvpn:
assignee: nobody → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/540908

Changed in manila-ui:
status: New → In Progress
Changed in bgpvpn:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/540909

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/540911

Changed in neutron-vpnaas-dashboard:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-vpnaas-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/540912

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/540913

Changed in heat-dashboard:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/540914

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat-dashboard (master)

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/540905
Reason: I uploaded two same patches wrongly...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-fwaas-dashboard (master)

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/540907
Reason: I uploaded two same patches wrongly...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on networking-bgpvpn (master)

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/540909
Reason: I uploaded two same patches wrongly...

Akihiro Motoki (amotoki)
Changed in neutron-vpnaas-dashboard:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to blazar-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/540920

Changed in blazar:
status: New → In Progress
Akihiro Motoki (amotoki)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-vpnaas-dashboard (master)

Reviewed: https://review.openstack.org/540912
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas-dashboard/commit/?id=49de8deaa22bdbaae7d69ac4191150f3ae02cfc6
Submitter: Zuul
Branch: master

commit 49de8deaa22bdbaae7d69ac4191150f3ae02cfc6
Author: Akihiro Motoki <email address hidden>
Date: Tue Feb 6 01:09:38 2018 +0900

    Correct django template pattern in babel-django.cfg

    Currently strings in Django templates cannot be translated
    because the current recommended file pattern "templates/**.html"
    does not match Django templates in subdirectories.
    This needs to be "**/templates/**.html".

    Change-Id: I11bf9397c7feea0ec3c7fef9a94963fe1c38010b
    Closes-Bug: #1747453

Changed in neutron-vpnaas-dashboard:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas-dashboard (master)

Reviewed: https://review.openstack.org/540913
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas-dashboard/commit/?id=e55851b5f8e02d82b071fd89426f73de6c140e95
Submitter: Zuul
Branch: master

commit e55851b5f8e02d82b071fd89426f73de6c140e95
Author: Akihiro Motoki <email address hidden>
Date: Tue Feb 6 01:08:24 2018 +0900

    Correct django template pattern in babel-django.cfg

    Currently strings in Django templates cannot be translated
    because the current recommended file pattern "templates/**.html"
    does not match Django templates in subdirectories.
    This needs to be "**/templates/**.html".

    Change-Id: I246aa6fb86a5f2c3a7a3cc9f537678ba8d3e2fdd
    Closes-Bug: #1747453

Changed in neutron-fwaas-dashboard:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat-dashboard (master)

Reviewed: https://review.openstack.org/540914
Committed: https://git.openstack.org/cgit/openstack/heat-dashboard/commit/?id=53ab2c9c4c1581de18264a25d8c79e7edfdc4ef6
Submitter: Zuul
Branch: master

commit 53ab2c9c4c1581de18264a25d8c79e7edfdc4ef6
Author: Akihiro Motoki <email address hidden>
Date: Tue Feb 6 01:07:28 2018 +0900

    Correct django template pattern in babel-django.cfg

    Currently strings in Django templates cannot be translated
    because the current recommended file pattern "templates/**.html"
    does not match Django templates in subdirectories.
    This needs to be "**/templates/**.html".

    Change-Id: I877e0a3703fa13b52e1df79f20c580b2604e7d1c
    Closes-Bug: #1747453

Changed in heat-dashboard:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-vpnaas-dashboard 1.2.1

This issue was fixed in the openstack/neutron-vpnaas-dashboard 1.2.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/freezer-web-ui 6.0.0.0rc1

This issue was fixed in the openstack/freezer-web-ui 6.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bgpvpn (master)

Reviewed: https://review.openstack.org/540911
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=064378b4b76d0b8cbe127e64ca44aabfd932ceae
Submitter: Zuul
Branch: master

commit 064378b4b76d0b8cbe127e64ca44aabfd932ceae
Author: Akihiro Motoki <email address hidden>
Date: Tue Feb 6 01:11:53 2018 +0900

    Correct django template pattern in babel-django.cfg

    Currently strings in Django templates cannot be translated
    because the current recommended file pattern "templates/**.html"
    does not match Django templates in subdirectories.
    This needs to be "**/templates/**.html".

    Change-Id: I8d68d847edebce37e37e671a1ad3eadddd4354e8
    Closes-Bug: #1747453

Changed in bgpvpn:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat-dashboard 1.0.2

This issue was fixed in the openstack/heat-dashboard 1.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to blazar-dashboard (master)

Reviewed: https://review.openstack.org/540920
Committed: https://git.openstack.org/cgit/openstack/blazar-dashboard/commit/?id=e5eed1e89da1e6af6a04d8f5e5172e71be4482b6
Submitter: Zuul
Branch: master

commit e5eed1e89da1e6af6a04d8f5e5172e71be4482b6
Author: Akihiro Motoki <email address hidden>
Date: Tue Feb 6 01:34:18 2018 +0900

    Correct django template pattern in babel-django.cfg

    Currently strings in Django templates cannot be translated
    because the current recommended file pattern "templates/**.html"
    does not match Django templates in subdirectories.
    This needs to be "**/templates/**.html".

    Translation is not enabled for blazar-dashboard but it is worth
    fixed to avoid unnecessary problems when translation is enabled.

    Change-Id: I74c741679c3f7bec28f053fc9704ff8d5bc5c536
    Closes-Bug: #1747453

Changed in blazar:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-ui (master)

Reviewed: https://review.openstack.org/540908
Committed: https://git.openstack.org/cgit/openstack/manila-ui/commit/?id=e8ac6fddaf59ef0e920743e5dc849682607cf1f9
Submitter: Zuul
Branch: master

commit e8ac6fddaf59ef0e920743e5dc849682607cf1f9
Author: Akihiro Motoki <email address hidden>
Date: Tue Feb 6 01:11:07 2018 +0900

    Correct django template pattern in babel-django.cfg

    The current recommended file pattern "templates/**.html" does not
    match Django templates in subdirectories.
    This needs to be "**/templates/**.html".

    Change-Id: I57aba8bef6b96bf4c5a6b34d8c6a167de93a6f5c
    Closes-Bug: #1747453

Changed in manila-ui:
status: In Progress → Fix Released
Revision history for this message
Akihiro Motoki (amotoki) wrote :

According to comment #17, a fix for freezer-web-ui was released.

Changed in freezer-web-ui:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-bgpvpn 9.0.0.0b1

This issue was fixed in the openstack/networking-bgpvpn 9.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila-ui 2.14.0

This issue was fixed in the openstack/manila-ui 2.14.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-fwaas-dashboard 1.4.0

This issue was fixed in the openstack/neutron-fwaas-dashboard 1.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/blazar-dashboard 1.1.0

This issue was fixed in the openstack/blazar-dashboard 1.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.