foto toolbar may follow elementary hig

Bug #1156533 reported by Tavecchio Luca
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Foto
Fix Committed
Low
Unassigned

Bug Description

foto home screen should have the menubar at the top as in the picture.

Revision history for this message
Tavecchio Luca (tavecchio-luca) wrote :
Revision history for this message
Erasmo Marín (erasmo-marin) wrote :

Is that in the elementary HIG?

Revision history for this message
Tavecchio Luca (tavecchio-luca) wrote :

just moved the toolbar from the bottom to the top in order to achieve a consistent look with elementary luna default apps...and to resemble.. i didn't want to modify the aspect of the "add album" function even if probably following elementary hig step by step it's supposed to be in the toolbar. I think that move it there will remove one peculiar aspect of the design of foto. a duplicate of the function should be a good idea.. maybe add delete rename function also in the toolbar should be good.
anyway i think that above all move the toolbar to the top should be a good move especially because it will make foto the first picture manager app to look consistent in luna considering that actually even shotwell that is in the default software line up doesn't follow the hig regard teh toolbar and the appmenu.
of course you already know these pages but just in the case you don't have them in your bookmarks:
http://elementaryos.org/docs/toolbars
http://elementaryos.org/docs/human-interface-guidelines/ui-toolkit-elements/toolbars/appmenu

Revision history for this message
Erasmo Marín (erasmo-marin) wrote :

yeah, I've read it before, but nowhere does it say that the toolbar can go at bottom. But I agree with you that the toolbar doesn't looks good at bottom in album view. By the other hand, I like how it looks in the image viewer.

Maybe I can put the toolbar at bottom in the image viewer, and at top in the album viewer. It is a good idea, because I want to add some new features, like events (automatic events by date) and categories, and these options, should go at top also. (I don't want to add a source view or something like that).

Revision history for this message
Tavecchio Luca (tavecchio-luca) wrote :

you can't find the reference in elementary hig because at the first page it say to refer to gnome hig where no reference is available in elementary hig:
http://dev.elementaryos.org/docs/read/human-interface-guidelines/human-interface-guidelines

in gnome hig at this page: https://developer.gnome.org/hig-book/3.0/toolbars-appearance.html.en
where it say that "By default, have your toolbars appear directly below the main menu bar."
in this case there is now the classic main menubar (some elementary apps like pantheon-files just have it hidden) but i guess we can assume that the right position is at the top.

anyway i agree with you, as i mentioned some where else you may split the application:
proposal A:
1) foto to manage them and with a top toolbar
2) foto-previewer with botton toolbar and just basic functionality (back,next, fullscreen, presentation)

proposal B:
as you mention above change just the home/album view

but i add:
-kill the appmenu at the bottom in "picture" mode
-information may be shown in a popover menu to avoid to clutter the interface with too many info like it does here even if referred to another function:
http://kxmylo.deviantart.com/art/Foto-mockup-333855559

Revision history for this message
Erasmo Marín (erasmo-marin) wrote :

foto 1.0 is using toolbars at top, in the headerbar. It's using it in the image viewer too, but maybe it can be changed to bottom. For now it will be at top.

Changed in foto:
milestone: none → foto-1.0
status: New → Fix Committed
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.