Foto

contractor menu popup not compliant to elementary HIG

Bug #1073554 reported by Camilo Higuita on 2012-10-31

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Foto	Fix Committed	Undecided	Unassigned

Bug Description

I believe the contractor menu popup doesn't follow elementary HIG, look: http://screencloud.net/v/2SgD

and in maya: http://screencloud.net/v/4hD0

Also I think the contractor icon would look better if it weren't inside of a button. Just like the screenshot attached would look better

See original description

Revision history for this message

Camilo Higuita (kxmylo) wrote on 2012-10-31:

new- Views.png Edit (292.4 KiB, image/png)

Revision history for this message

Erasmo Marín (erasmo-marin) wrote on 2012-10-31:

No specs about what you say, granite-demo IS NOT an example of elementary HIG, it's just an API example.

http://elementaryos.org/docs/human-interface-guidelines/desktop-integration/contractor

also, we can't use a Granite.Widgets.ContractorMenu for now, because it's unstable api.

I think PopOver is a nice way to handle this.

About the "button" thing, it will look better when I adding more functionality to that group button. It will be related to "image transformations", and the "searchbar" will be removed, so we will have a very simetric thing, following the HIG for toolbars (left = more important, right = less important).

Revision history for this message

Camilo Higuita (kxmylo) wrote on 2012-10-31:

I see. Yes, it will look better when it has more buttons grouped, is just that looks odd alone. So the searchbar will only be displayed on the album view?

Revision history for this message

Eduard Gotwig (gotwig) wrote on 2012-12-09: Re: Toolbar redesign needed

What is about the new "views" part? Will it be accepted?

Changed in foto:
status:	New → Fix Committed
summary:	- Contractor menu looks odd + Toolbar redesign needed
description:	updated
Changed in foto:
status:	Fix Committed → In Progress