Support PNG format icons

Bug #1697735 reported by Sam Hewitt
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Folder Color
Fix Released
Low
costales

Bug Description

This extension seems to only look for icons of the SVG format, but many themes ships icons in PNG format (as I do with Paper & Moka) and Folder Color doesn't work for the users of those themes.

I also suggest to expand support maybe looking for icons with the following names:

folder-red
folder-blue
folder-cyan
folder-grey
folder-black
folder-brown
folder-green
folder-orange
folder-violet
folder-yellow
folder-magenta

As icons with those names are already a part of many themes to support a similar function in KDE's Dolphin, which if were detected by Folder Colors would expand the range of themes supported significantly (without any effort on the behalf of theme developers).

Related branches

Revision history for this message
costales (costales) wrote :

Note for me: Update readme

Changed in folder-color:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → costales (costales)
milestone: none → 0.0.80
Revision history for this message
costales (costales) wrote :

Note for me: Check it will work with this theme:
https://github.com/snwh/paper-icon-theme/issues/586

Revision history for this message
costales (costales) wrote :

Hi Sam :)

I was looking to fix this bug... but I have a few doubts.

Please, could you tell me which Dolphin icon themes are using the folder-<color> icon? I didn't find any of them.

Even your (awesome :)) themes doesn't have the folder-<color> icons.

As I see it now, I'll do a lot of work and touch a so stable folder-color version for no themes :P

Thanks in advance!

costales (costales)
Changed in folder-color:
status: Triaged → Fix Committed
costales (costales)
Changed in folder-color:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.