[NPHVJ] Update view ROI after view moves, not just on mouseup

Bug #359845 reported by Ben Karel
2
Affects Status Importance Assigned to Milestone
Firefox JPEG 2000 Plugin
Fix Committed
Undecided
Ben Karel

Bug Description

Currently, NPHVJ sends a new region of interest request on mouseup only. This should be generalized so that when the viewport is updated by any means, including keyboard or JS, the ROI may also be updated.

The advantage of mouseup is that it serves as a marker for the user "settling" on a particular location; we can be relatively sure that the viewport will stop moving for at least a few tenths of a second after a mouseup. To avoid doing unnecessary work rendering a ROI that will immediately be moved, a replaceable timeout should be set on each view move.

This could be combined with a strategy of requesting and rendering very small ROIs immediately (every few pixels, typically), with the larger/complete ROI requested after some cooldown period.

Tags: nphvj
Revision history for this message
Ben Karel (eschew) wrote :

Initial fix in revision 363 of branch nphvj.

Changed in helioviewer:
assignee: nobody → eschew
status: New → Fix Committed
summary: - [NPHVJ] Generalized ROI updating
+ [NPHVJ] Update view ROI after view moves, not just on mouseup
affects: helioviewer.org → firefoxjpeg2000
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.