shotwell crashed with SIGSEGV in g_menu_model_get_n_items()

StacktraceTop:
 g_menu_model_get_n_items (model=0x0) at ../../../../gio/gmenumodel.c:494
 gtk_application_window_update_shell_shows_app_menu (window=0x55b0b07da470, settings=<optimized out>) at ././gtk/gtkapplicationwindow.c:316
 gtk_application_window_real_realize (widget=0x55b0b07da470) at ././gtk/gtkapplicationwindow.c:683
 _g_closure_invoke_va (closure=0x55b0b05af980, return_value=0x0, instance=0x55b0b07da470, args=0x7fff28ea8670, n_params=0, param_types=0x0) at ../../../../gobject/gclosure.c:867
 g_signal_emit_valist (instance=0x55b0b07da470, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7fff28ea8670) at ../../../../gobject/gsignal.c:3300

Status changed to 'Confirmed' because the bug affects multiple users.

On my computer the bug manifested itself when I merely connected a USB flash card, without displaying images. I never use Shotwell but Ubuntu 17.10 insists on opening it when I connect a flash card with photos, although my settings for photos are on “open directory” as they always were – but that is a different issue.

Disconnecting, removing, re-inserting and reconnecting the flash card within the same X session made Shotwell start without problems.

By the way I am using XOrg under Ubuntu 17.10, since *putty* has problems with Xwayward (bug 1720905). During the few days when I was using Xwayward the problem did not appear, though I connected the same flash card at least once.

Cropped image and used "send to"

Happens to me whenever I make edits to a photo. It keeps asking me to save repeatedly even when the document has already been saved and does so again when I reopen the file (which shows the changes!).

Doesn't actually "crash" on me though if that's different. It just thinks it crashes as far as I can tell, Shotwell itself seems to keep running... maybe a subcomponent that Shotwell itself is properly recovering from?

exiting without saving after many modifications on a .jpg

corrado@corrado-HP-p4-cc-0620:~$ inxi -Fx
System: Host: corrado-HP-p4-cc-0620 Kernel: 4.15.0-23-generic x86_64 bits: 64 compiler: gcc v: 7.3.0
           Desktop: Gnome 3.28.2 Distro: Ubuntu 18.10 (Cosmic Cuttlefish)
Machine: Type: Laptop System: Hewlett-Packard product: HP 250 G3 Notebook PC v: 0991100000000000000600087
           serial: <root required>
           Mobo: Hewlett-Packard model: 2211 v: 86.49 serial: <root required> UEFI: Insyde v: F.36
           date: 12/18/2014
Battery: ID-1: BAT1 charge: 22.2 Wh condition: 22.2/22.2 Wh (100%) model: 13-42 OA03031 status: Full
CPU: Topology: Dual Core model: Intel Core i5-4210U bits: 64 type: MT MCP arch: Haswell rev: 1
           L2 cache: 3072 KiB
           flags: lm nx pae sse sse2 sse3 sse4_1 sse4_2 ssse3 vmx bogomips: 19156
           Speed: 798 MHz min/max: 800/2700 MHz Core speeds (MHz): 1: 798 2: 798 3: 798 4: 799
Graphics: Card-1: Intel Haswell-ULT Integrated Graphics driver: i915 v: kernel bus ID: 00:02.0
           Display: x11 server: X.Org 1.19.6 driver: i915 resolution: 1366x768~60Hz
           OpenGL: renderer: Mesa DRI Intel Haswell Mobile v: 4.5 Mesa 18.1.2 direct render: Yes
Audio: Card-1: Intel Haswell-ULT HD Audio driver: snd_hda_intel v: kernel bus ID: 00:03.0
           Card-2: Intel 8 Series HD Audio driver: snd_hda_intel v: kernel bus ID: 00:1b.0
           Sound Server: ALSA v: k4.15.0-23-generic
Network: Card-1: Realtek RTL8101/2/6E PCI Express Fast/Gigabit Ethernet driver: r8169 v: 2.3LK-NAPI
           port: 3000 bus ID: 08:00.0
           IF: enp8s0 state: down mac: 5c:b9:01:06:ba:ce
           Card-2: Ralink RT3290 Wireless 802.11n 1T/1R PCIe driver: rt2800pci v: 2.3.0 bus ID: 09:00.0
           IF: wlo1 state: up mac: ac:d1:b8:82:03:5d
Drives: HDD Total Size: 465.76 GiB used: 70.82 GiB (15.2%)
           ID-1: /dev/sda vendor: Seagate model: ST500LT012-1DG142 size: 465.76 GiB
Partition: ID-1: / size: 31.25 GiB used: 6.09 GiB (19.5%) fs: ext4 dev: /dev/sda4
           ID-2: swap-1 size: 4.00 GiB used: 0 KiB (0.0%) fs: swap dev: /dev/sda2
Sensors: System Temperatures: cpu: 42.0 C mobo: 42.0 C
           Fan Speeds (RPM): N/A
Info: Processes: 241 Uptime: 4h 38m Memory: 3.79 GiB used: 1.96 GiB (51.9%) Init: systemd runlevel: 5
           Compilers: gcc: N/A Shell: bash v: 4.4.19 inxi: 3.0.13
corrado@corrado-HP-p4-cc-0620:~$

https://gitlab.gnome.org/GNOME/shotwell/commit/77514d6960f563e1cb79f8510e123ee49461d24d

Thanks Jens!

I've uploaded the fix to disco and cosmic now, I'm going to do bionic a bit later while updating to 0.28.4

This bug was fixed in the package shotwell - 0.30.1-0ubuntu4

---------------
shotwell (0.30.1-0ubuntu4) disco; urgency=medium

  * debian/patches/git_notification_segfault.patch:
    - direct: Fix crash when dismissing modifications (lp: #1723181)

 -- Sebastien Bacher <email address hidden> Wed, 07 Nov 2018 15:39:16 +0100

Hello Jan, or anyone else affected,

Accepted shotwell into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shotwell/0.30.1-0ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Jan, or anyone else affected,

Accepted shotwell into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shotwell/0.28.4-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Is there someone who was able to trigger the issue/having an hidpi screen to test the fix?

Using 0.30.1-0ubuntu3 on cosmic it works without visible issue/regression, the error tracker still see reports though, it might improve thing/fix some cases but there is still an issue. Setting as verification-cosmic-done on the basis that it's not a regression and might still improve things even if it's not perfect

0.28.4-0ubuntu1 is in the same case

This bug was fixed in the package shotwell - 0.30.1-0ubuntu3

---------------
shotwell (0.30.1-0ubuntu3) cosmic; urgency=medium

  * debian/patches/git_notification_segfault.patch:
    - direct: Fix crash when dismissing modifications (lp: #1723181)

 -- Sebastien Bacher <email address hidden> Wed, 07 Nov 2018 15:39:16 +0100

The verification of the Stable Release Update for shotwell has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package shotwell - 0.28.4-0ubuntu1

---------------
shotwell (0.28.4-0ubuntu1) bionic; urgency=medium

  * New bugfix update (lp: #1802895)
    - Fix "Out of memory" issues when scrolling through large collections
      (lp: #1606491)
  * debian/patches/git_notifications_segfault.patch:
    - direct: Fix crash when dismissing modifications (lp: #1723181)

 -- Sebastien Bacher <email address hidden> Mon, 12 Nov 2018 11:43:31 +0100