cannot show more than 15 photos when aggregated by Photos

Bug #1623061 reported by Kyle Nitzsche
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Facebook Scope
Fix Committed
High
Penk Chen

Bug Description

Regression.

The photos aggregator allows the user to set the number of photos (cardinality) to display from each child scope. facebook photos now cannot show more than 15 photos.

I suppose it is because "count" stops iteration due to this new code query.cpp

    if (metadata_.is_aggregated()) {
        QMapIterator<std::string, std::string> iter(albumList_);
        int count = 0;
        while(iter.hasNext() && count < 6) {
            iter.next();
            QList<api::Photo> photoList = client_->getAllPhotos(iter.key());

            Q_FOREACH(const auto& photo, photoList) {
                if (push_photo_item(reply, iter.value(), photo, has_types))
                    count++;
            }
        }
        return;
    }

Tags: ota14 store
Changed in facebook-scope:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Zhang Enwei (zhangew401)
Zhang Enwei (zhangew401)
Changed in facebook-scope:
status: Confirmed → In Progress
Revision history for this message
Zhang Enwei (zhangew401) wrote :

Please use attached two scopes for testing, thanks.

Zhang Enwei (zhangew401)
Changed in facebook-scope:
status: In Progress → Fix Committed
assignee: Zhang Enwei (zhangew401) → Penk Chen (penk)
summary: - cannot show more than 15 photos hen aggregated by Photos
+ cannot show more than 15 photos when aggregated by Photos
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi Enwei.

When you provide a scope for QA and release, please be sure to add a bzr tag to the branch where the tag is the click package version for release.

This allows us to build any released click package from the branch by simply reverting the branch to the revision, like this:
bzr revert -r tag:1.30

I see the current trunk is click package 1.33

I have tagged trunk to 1.33.

Penk, please QA and release the attached to store and for ota14.

tags: added: ota14 store
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.