Geolocation lookup is broken
Bug #1103412 reported by
Jonathan Gilbert
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| eyefi |
Fix Committed
|
Undecided
|
Unassigned | ||
Bug Description
Currently the Geolocation lookup via Google isn't working correctly. It appears to:
- Send JSON which is not formatted as Google wants it to be
- Misreads the result?
Additionally Google seems to be completely ignoring the request JSON (my investigation showed it was no liking having no content type header), and instead falling back to locating _where the request is served from_ (i.e. your ISP).
Related branches
lp://staging/~jpg0/eyefi/update-geolocate
- Robert Jordens: Pending requested
-
Diff: 35 lines (+7/-4)2 files modifiedeyefi/actions.py (+1/-1)
eyefi/google_loc.py (+6/-3)
Revision history for this message
| Robert Jordens (jordens) wrote | #1 |
| Changed in eyefi: | |
| status: | New → Fix Released |
| status: | Fix Released → Fix Committed |
To post a comment you must log in.
I rewrote all that code. Should be fine now.
As of r42.