Adjust to Zero does not set item status to Lost and Paid

Bug #1830089 reported by tji@sitka.bclibraries.ca
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.6
Fix Committed
Medium
Unassigned
3.7
Fix Released
Medium
Unassigned

Bug Description

EG 3.1.7

With the library setting To Use Lost and Paid copy status set to True, we see the following behaviour:

For a bill amount of 14.82, apply cash payment of 14.80, then use Adjust to Zero to settle the leftover 2 cents. The item status remains Lost.

For a bill amount of 16.00, apply cash payment of 16.00. The item status is set to Lost and Paid.

tags: added: billing
Revision history for this message
tji@sitka.bclibraries.ca (tji) wrote :

Voiding lost (full or partial) bills does not change the item status to Lost and Paid, either.

For a lost bill with two billings: replacement charge and processing fee. Make payment on the replacement cost, go to Full Details to void the processing fee. The bill is resolved, but the item status remains Lost.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

I've opened bug 1832410 for the issue with voiding bills, which is a related but separate bug.

Working branch user/jeffdavis/lp1830089-lost-and-paid-on-adjust-to-zero has a fix for adjust-to-zero:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1830089-lost-and-paid-on-adjust-to-zero

The fix refactors some code so that regular payments and adjust-to-zero use the same subroutine to close the transaction and adjust item status. It's slightly inelegant because they handle errors differently: make_payments wants a text string that it can pass to an error-handling function, while adjust_bills_to_zero_manual expects an event. But it works.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.4-beta1
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
status: New → Confirmed
milestone: 3.4-beta1 → 3.4-beta2
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: signedoff
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
assignee: Terran McCanna (tmccanna) → nobody
assignee: nobody → Terran McCanna (tmccanna)
assignee: Terran McCanna (tmccanna) → nobody
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.5.0
Changed in evergreen:
milestone: 3.5.0 → 3.5.1
Changed in evergreen:
milestone: 3.5.1 → 3.5.2
Changed in evergreen:
milestone: 3.5.2 → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
tags: added: circ-billing
removed: billing
no longer affects: evergreen/3.1
no longer affects: evergreen/3.2
no longer affects: evergreen/3.3
no longer affects: evergreen/3.4
no longer affects: evergreen/3.5
Changed in evergreen:
milestone: 3.7.2 → 3.7.3
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed all the way to rel_3_6. Thanks, Jeff and Terran!

Changed in evergreen:
milestone: 3.7.3 → 3.8.0
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.