Evergreen

Cash Reports allows start date after end date

  1. Series 3.11
  2. Bug #2002343
Bug #2002343 reported by Susan Morrison
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
Evergreen 3.12-beta
3.11
Fix Committed
Medium
Unassigned
Evergreen 3.11.2

Bug Description

Evergreen 3.8 and 3.10

In the Cash Reports interface, the date pickers do not check to make sure the end date is after the start date for the time period selected. If a start date is after the end date, it produces no results, but it would be helpful to have an error message to alert the issue.

Revision history for this message
Elizabeth Davis (elidavis) wrote :

Confirming that I see this in 3.9.2.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for catching this, Susan, and for confirming it, Elizabeth. Here is a branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2002343-validate-cash-reports-dates

tags: added: pullrequest
Jane Sandberg (sandbergja)
Changed in evergreen:
importance: Undecided → Wishlist
Revision history for this message
Galen Charlton (gmc) wrote :

Signoff pushed to user/gmcharlt/lp2002343_signoff. Note that the signoff includes a follow-up patch to tidy up after the patch for bug 2000482 broken the intended columnar (on large screens) layout of the inputs on this page.

tags: added: signedoff
Changed in evergreen:
importance: Wishlist → Medium
Revision history for this message
Galen Charlton (gmc) wrote :

Also noting that I've changed this from a wishlist to a bug; while adding the additional validation is an enhancements, the prior lack of validation is arguably a bug.

Changed in evergreen:
milestone: none → 3.11.1
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.11.1 → 3.12-beta
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks All. Does the thing. Layout improved. Tests/lints clean. Merged to main and 3.11, including a tiny follow up patch to make the --configuration=production build happy (rename template variable).

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.