Fast Item Add Not Working from MARC Edit

Bug #1986706 reported by Jennifer Pringle
46
This bug affects 9 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
3.10
Fix Committed
Medium
Unassigned

Bug Description

Evergreen 3.9
Chrome

When cataloguing items if you check the box for Add Item on the MARC Edit tab, enter your call number and barcode and then click Save Changes the new Holdings Editor opens but the barcode field is blank.

The call number is being filled with the value entered in Add Item.

In 3.7 the values for both the call number and barcode would appear when the Holdings Editor opened.

Revision history for this message
Shannon Dineen (sdineen) wrote :

Confirming this is still an issue in 3.10 for bug squashing week

Tested on https://bugsquash.mobiusconsortium.org/
Chrome
WIN 10

Andrea Neiman (aneiman)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Confirming that this seems to also be broken in the Create MARC Record interface.
/eg/staff/cat/catalog/new_bib

It looks like it is redirecting to the Angular staff catalog... in my test system
/eg2/en-US/staff/catalog/record/

I'm fuzzy about how this is supposed to work.. it looks like the cache of the data is still being created in memcached. I think a window is supposed to open to the /cat/volcopy with the cache key.

if (key) {
  var url = egCore.env.basePath + 'cat/volcopy/' + key;
  $timeout(function() { $window.open(url, '_blank') });

But instead the only page that is being opened is the catalog
eg2/en-US/staff/catalog/record/416649

I'm not spotting where the redirect is.

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Ooops, it was chrome blocking pop ups that was stopping the fast item add from loading the volcopy.

Once I enabled popups for the site the volcopy interface opened with the call number and barcode filled in.

So it may be fixed in 3.11.
Josh

Revision history for this message
Christine Morgan (cmorgan-z) wrote :

I tested this on https://terran-main.gapines.org/ during Bug Squashing Week August 2023 and can confirm that the issue still exists.

When selecting Add Item from an existing MARC record and entering a call number and a barcode, clicking Save Changes brought me to the Holdings Editor with the Call Number Label filled in but the Barcode box was blank.

When creating a new MARC record with Add Item selected and entering a call number and a barcode, clicking Save brought to the Item Table tab (or whatever tab I had set as the default) in the Staff Catalog. Neither field was carried over.

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Hello, I think I see how the barcode data isn't getting entered and how to add it.

Working branch at : user/stompro/lp1986706_angular_fastitem_add_barcode

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1986706_angular_fastitem_add_barcode

Josh

tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Christine Morgan (cmorgan-z)
Revision history for this message
Christine Morgan (cmorgan-z) wrote :

Josh's patch for carrying over the barcode works well.

I am signing off of this patch because I think it is an improvement over the current behavior.

I have tested this code and consent to signing off on it with my name,
Christine Morgan and my email address,
<email address hidden>.

Changed in evergreen:
assignee: Christine Morgan (cmorgan-z) → nobody
Michele Morgan (mmorgan)
tags: added: signedoff
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

Works as advertised!

Pushed to rel_3_10 and above.

Thanks Josh and Christine!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Michele Morgan (mmorgan) → nobody
milestone: none → 3.11.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.