Three Library Settings Have Group in Wrong Spot

There are 5 library settings that have a GUI: prefix in the label now in my upgraded 3.11.0 test system.

Two of them also have the grp set to gui.

Should all of them have the "GUI: " removed from the label and have that only be in the grp field?

egdbdev-2023-06-09=# select name,label,grp from config.org_unit_setting_type where label~'^GUI';
-[ RECORD 1 ]--------------------------------------------------
name | ui.hide_copy_editor_fields
label | GUI: Hide these fields within the Item Attribute Editor
grp | gui
-[ RECORD 2 ]--------------------------------------------------
name | ui.patron.edit.au.guardian.show
label | GUI: Show guardian field on patron registration
grp |
-[ RECORD 3 ]--------------------------------------------------
name | ui.patron.edit.au.guardian.suggest
label | GUI: Suggest guardian field on patron registration
grp |
-[ RECORD 4 ]--------------------------------------------------
name | ui.patron.edit.guardian_required_for_juv
label | GUI: Juvenile account requires parent/guardian
grp |
-[ RECORD 5 ]--------------------------------------------------
name | ui.staff.traditional_catalog.enabled
label | GUI: Enable Traditional Staff Catalog
grp | gui

There are 165 out of 594 org unit setting types that include a prefix like that in the label, so it isn't a rare pattern to follow for naming the settings. But only 5 out of all 250 settings with grp='gui' have the prefix. So it does probably make sense to remove it.

We could also just add the missing grp setting but leave the label prefix.

Josh

I agree with setting the grp on the 3 settings. I mostly agree with removing the group and colon from the labels, but I think it is less important.

These also appear to be the only 3 settings missing the grp.

I've added series targets to the bug because I have confirmed the missing grp data in 3.10 and main. (I've also confirmed it in 3.7.3, but we don't support such an old release any longer.)