Wishlist: Ability to filter out deleted shelving locations in Shelving Locations Editor

Bug #1917092 reported by Jennifer Pringle
112
This bug affects 23 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
3.10
Confirmed
Medium
Unassigned

Bug Description

Evergreen 3.5.1

In the angularized Shelving Locations Editor deleted shelving locations display with the Is Deleted? flag set to yes. This is a change in behaviour from the dojo interface where deleted shelving locations did not display.

It would be useful if there was a way to filter out or hide deleted shelving locations when working in this interface, especially for libraries that have a significant number of shelving locations.

Revision history for this message
Elaine Hardy (ehardy) wrote :

Even color coding would be helpful, although the ability to hide would be best.

Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
importance: Undecided → Medium
Revision history for this message
Dan Briem (dbriem) wrote :

I'm looking at the Shelving Locations Editor on 3.6.2 and there are filters on each column. I can filter out deleted locations by filtering "Is Deleted?" False. Is this existing functionality enough or should deleted items just not show at all in this interface?

Revision history for this message
Elaine Hardy (ehardy) wrote :

3.6.1 doesn't have a way to filter the shelving locations. Neither did 3.4.

My preference would be to not see deleted shelving locations in the editor. However, I can see where it might be useful to be able to. Being able to filter out "is deleted?" false would be good. Having the setting stick would be better so I wouldn't have to choose it each time I opened the editor if I never wanted to see deleted locations. Does it stick in 3.6.2?

Revision history for this message
Michele Morgan (mmorgan) wrote :

To address Dan's question, I definitely think that deleted shelving locations should be hidden by default. I'm not sure whether it would be useful for users to have access to the deleted shelving locations at all. Having access, as they do now, allows users to UNdelete a previously deleted shelving location.

To address Elaine's question, filter preferences and grid settings do not stick in the Shelving Location Editor in 3.6.2/master. Grid settings, at least, should. I don't see a bug report, so I will open one.

Revision history for this message
Elaine Hardy (ehardy) wrote :

As long as the bug exists where a shelving location with items attached can be deleted, it might be best to be able to view deleted shelving locations in the editor so if one is mistakenly deleted, it can be undeleted easily. I do agree without that bug that deleted locations don't need to be visible in the editor.

Revision history for this message
Terran McCanna (tmccanna) wrote :

In previous versions, you couldn't delete shelving locations if they had holdings, so having them disappear entirely made sense.

However, with the other outstanding bug that allows you to delete shelving locations when there are holdings attached (https://bugs.launchpad.net/evergreen/+bug/1910546), making them disappear entirely makes less sense.

Revision history for this message
Michele Morgan (mmorgan) wrote :

Related: bug 1917782 - Angular Shelving Locations Editor Grid Settings won't save.

Revision history for this message
Rogan Hamby (rogan-hamby) wrote :

Noting that https://bugs.launchpad.net/evergreen/+bug/1910546 has had a fix committed now. I think hiding the deleted locations makes sense.

Revision history for this message
John Amundson (jamundson) wrote :

Noting that https://bugs.launchpad.net/evergreen/+bug/2002435 will add the action to undelete a shelving location, so there should be some way to view deleted shelving locations, though they should be hidden in some capacity by default.

Revision history for this message
Brett French (bsfrench) wrote : Re: [Bug 1917092] Re: Wishlist: Ability to filter out deleted shelving locations in Shelving Locations Editor

Thanks, John!

On Mon, Feb 27, 2023 at 11:16 AM John Amundson <email address hidden>
wrote:

> Noting that https://bugs.launchpad.net/evergreen/+bug/2002435 will add
> the action to undelete a shelving location, so there should be some way
> to view deleted shelving locations, though they should be hidden in some
> capacity by default.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1917092
>
> Title:
> Wishlist: Ability to filter out deleted shelving locations in Shelving
> Locations Editor
>
> Status in Evergreen:
> Confirmed
>
> Bug description:
> Evergreen 3.5.1
>
> In the angularized Shelving Locations Editor deleted shelving
> locations display with the Is Deleted? flag set to yes. This is a
> change in behaviour from the dojo interface where deleted shelving
> locations did not display.
>
> It would be useful if there was a way to filter out or hide deleted
> shelving locations when working in this interface, especially for
> libraries that have a significant number of shelving locations.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1917092/+subscriptions
>
>

--

Brett French | Library Applications Associate II | CW MARS

<email address hidden> | 508-755-3323 x323 <%28508%29%20755-3323>

https://www.cwmars.org

he/they

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Here's a branch that filters out deleted shelving locations: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1917092-filter-acpl-to-non-deleted

It uses the good ol' filters in the grid headers to do so, meaning that in rare cases that a staff member needs to find a deleted shelving location, they can do so by simply editing or clearing the filter.

Let me know what you think!

tags: added: pullrequest
Revision history for this message
Elizabeth Thomsen (et-8) wrote :

I have tested this code and consent to signing off on it with my name, Elizabeth Thomsen, and my email address, <email address hidden>.

Michele Morgan (mmorgan)
tags: added: signedoff
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

This is a good solution. Deleted shelving locations are filtered out of the display by default when the Shelving Location Editor is opened. Clicking the Remove Filters button or clearing the filter on the Is Deleted column will reveal the deleted locations. Hiding the Is Deleted column will remove that column from display, but deleted shelving locations will still be filtered out.

Pushed, along with a release note, to rel_3_11, and main. There were conflicts when applying to rel_3_10, so it has not been pushed there yet.

Thanks Jane and Elizabeth!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Michele Morgan (mmorgan) → nobody
milestone: none → 3.11.2
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: 3.11.2 → 3.10.4
milestone: 3.10.4 → 3.11.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.