Evergreen

Staff Client eg grid not sorting alphabetically

  1. Series 3.10
  2. Bug #1912840
Bug #1912840 reported by Llewellyn Marshall
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
New
Undecided
Unassigned
3.10
New
Undecided
Unassigned
3.11
New
Undecided
Unassigned
3.9
Won't Fix
Undecided
Unassigned

Bug Description

Version: Evergreen 3.5.1
Browser: tested in Firefox & Chrome

When sorting by text columns in the AngularJS staff client, we found that records in all caps were sorted above lowercase records. This was confusing to catalogers trying to look at holds on a very popular record. They'd assumed that records in all caps would be treated the same as lower case strings and intermixed within them. I found that the comparator for the data in the grid service was using the same comparison function regardless of type.

I've created a code patch that addresses this issue by utilizing different comparator functions based on the type of the data. For strings, the data is compared while lower case.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/lew/NC22753-eg-grid-string-sort

Revision history for this message
Cheryl Middleton (cheryl-middleton) wrote :

 Pushing this code patch to production solved the issue we were experiencing when attempting to sort large numbers of holds on catalog records - sorting alphabetically by patron name to determine as closely as possible specific patron's position in the queue

Tiffany Little (tslittle)
tags: added: sorting
Blake GH (bmagic)
tags: added: pullrequest
Revision history for this message
Garry Collum (gcollum) wrote :

I tested by changing some titles in the concerto database to lower case and then sorted in a patron's items out and hold's list. The patch works perfectly. A signed-off branch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/LP1912840-eg-grid-string-sort-signoff

tags: added: signedoff
Terran McCanna (tmccanna)
Changed in evergreen:
milestone: none → 3.9.1
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.9.1 → 3.9.2
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: 3.9.2 → 3.10.1
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.10.1 → 3.10.2
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.10.2 → none
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for the patch, Llewellyn, and for the testing, Garry. I was about to push it, but noticed:

1. The commit is missing your signoff, Llewellyn.
2. The commit doesn't include the LP number in the commit message.
3. There is still a console.log debugger line in the commit.

With your permission, Llewellyn, I can amend your commit to add the first two, and push a follow-up commit for the third item. Or, if you're up for amending this commit, that would also be great.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.