Evergreen

Angular: the Mark Damaged and Mark Missing dialogs are missing some i18n directives

  1. Series 3.10
  2. Bug #1840990
Bug #1840990 reported by Jane Sandberg
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
Evergreen 3.11.2
3.10
Fix Committed
Medium
Unassigned
Evergreen 3.10.4

Bug Description

In current master, within the experimental staff catalog, there are some English-language strings that should be marked for translation.

They are in these files:
* https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/eg2/src/app/staff/share/holdings/mark-missing-dialog.component.html
* https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/eg2/src/app/staff/share/holdings/mark-damaged-dialog.component.html

For example, the string "Title: " should be made translatable into non-English languages on this line: https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/eg2/src/app/staff/share/holdings/mark-damaged-dialog.component.html#L20

To check your work, you might:
* in the Open-ILS/src/eg2 directory, run this command: npm run export-strings
* Check the resultant Open-ILS/src/eg2/src/locale/messages.xmb file and make sure that the correct strings are included

This might be a good project for somebody new to the angular code!

Revision history for this message
Jane Sandberg (sandbergja) wrote :

P.S. this section from the Angular documentation is really helpful: https://angular.io/guide/i18n#template-translations

tags: added: bitesize
Steven Mayo (stmayo)
Changed in evergreen:
assignee: nobody → Steven Mayo (stmayo)
Revision history for this message
Steven Mayo (stmayo) wrote :

I haven't tested very rigorously as I don't have a separate locale installed yet but I think https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/smayo/lp1840990-Mark_Damaged_Mark_Missing_i18n should do it.

tags: added: pullrequest
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Steven. It looks good overall. One small comment: I don't believe those two buttons in mark-missing-dialog.component.html need aria-labels. Screen readers should just announce the text inside the button tags, making the duplicate aria-label text redundant.

A good way to confirm in Firefox would be to right click on one of the buttons, select "Inspect Accessibility Properties", and confirming that the Name element is, say, "Mark Missing". In Chrome/Edge, you can similarly right click on the button, navigate from the "Styles" tab to the "Accessibility" tab, and confirm the element's accessible name is "Mark Missing".

Revision history for this message
Steven Mayo (stmayo) wrote :

Thanks, Jane! That's very helpful for editing other things. Every bit of advice is useful when you're learning this much.

I've undone the change to those buttons and pushed again. (after checking that they still have accessibility text)

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for this fix, Steven! I confirmed that those strings are now being included in the xmb file, making them available for translators to work with. Pushed to the rel_3_10, rel_3_11, and main branches, for inclusion in 3.10.4, 3.11.2, and the 3.12 series.

Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Medium
assignee: Steven Mayo (stmayo) → nobody
milestone: none → 3.11.2
tags: added: signedoff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.