Evergreen

integrated search box on Evergreen staff client portal page - empty results when searching terms with Czech chararcters

  1. Series 2.2
  2. Bug #1081576
Bug #1081576 reported by Eva Cerninakova
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.5.0-m1
2.2
Fix Released
Medium
Unassigned
Evergreen 2.2.10
2.3
Fix Released
Medium
Unassigned
Evergreen 2.3.8
2.4
Fix Released
Medium
Unassigned
Evergreen 2.4.1

Bug Description

When searching for terms containing extended Czech characters (like "aplikovaná psychologie" , "dějiny", "Baštecká", "manažerská" etc.) on Evergreen Staff Client Portal Page (Evergreen version 2.2.2), empty results are returned, see http://knihovna.jabok.cz/Evergreen/bugs/integrated_search_box.jpg

I guess it is caused by missing UTF-8 charset attribute in form in the source code of the Portal page.

Eva Cerninakova (ece)
summary: integrated search box on Evergreen staff client portal page - empty
- results Web integrated search box - empty results when searching word
- with Czech chararcters
+ results when searching word with Czech chararcters
summary: integrated search box on Evergreen staff client portal page - empty
- results when searching word with Czech chararcters
+ results when searching terms with Czech chararcters
Revision history for this message
Michael Peters (mrpeters) wrote :

I'll take a look at this, since I created it. Thanks for pointing it out.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Michael Peters (mrpeters) wrote :

Eva,

Could you give this a test?

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=94a935b8a59d94d553491b7a69215a5c9e970ad3

-Mike

Michael Peters (mrpeters)
Changed in evergreen:
assignee: nobody → Michael Peters (mrpeters)
Revision history for this message
Pasi Kallinen (paxed) wrote :

This bug still seems to happen, with the TPAC.

Search for anything containing non-US ASCII characters directly from the staff client portal input bar. The search results page shows the searched string as containing unknown UTF characters (U+FFFD, the replacement char).

mrpeters' fix above didn't work.

Revision history for this message
Dan Scott (denials) wrote :

The fix is to change the escape() calls to encodeURIComponent() calls.

Revision history for this message
Ben Shum (bshum) wrote :

Dan Scott took a look at this and suggested replacing escape() with encodeURIComponent() to better handle utf8 characters.

See working branch at: working/user/bshum/lp1081576

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1081576

tags: added: pullrequest
tags: added: i18n
Changed in evergreen:
assignee: Michael Peters (mrpeters) → nobody
milestone: none → 2.5.0-m1
Revision history for this message
Pasi Kallinen (paxed) wrote :

Works for me. Signoff at user/paxed/lp1081576-signoff

tags: added: signedoff
Revision history for this message
Ben Shum (bshum) wrote :

Thanks for testing Pasi! I've picked this to master, rel_2_4, rel_2_3. Also rel_2_2, though that required a tiny bit of massaging since the code there is slightly different due to xulrunner differences between branches.

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.