OpenLibrary links display in Firefox and Internet Explorer less than ideal & need proxying for borrowed content

Bug #801587 reported by Dan Scott
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Incomplete
Medium
Dan Scott

Bug Description

In master, the OpenLibrary links display properly in Chrome but the event model seems to be different for Firefox and Internet Explorer, where the entire list of ISBNs gets run through the fetchOpenLibraryLinks() method for each record when it is displayed (rather than just once for the entire page). This results in duplicate OL links being appended for each record, rather than just one.

Setting a global var fetchedOpenLibraryLinks prevents successive iterations from fetching and displaying the content - it doesn't feel like the proper way to resolve the problem, but it does resolve it, and that's better than the current situation.

Also - "Borrow online" links need to be proxied to support remote access, so offer var localProxyPrefix for that purpose.

Tags: addedcontent
Revision history for this message
Dan Scott (denials) wrote :
Changed in evergreen:
importance: Undecided → Medium
status: New → Confirmed
Dan Scott (denials)
Changed in evergreen:
assignee: nobody → Dan Scott (denials)
Dan Scott (denials)
Changed in evergreen:
assignee: Dan Scott (denials) → nobody
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Dan,

What the status on this one? Is it still relevant?

Jason

Revision history for this message
Ben Shum (bshum) wrote :

Assigning to Dan for comment/status update.

Changed in evergreen:
assignee: nobody → Dan Scott (denials)
status: Confirmed → Incomplete
Elaine Hardy (ehardy)
tags: added: addedcontent
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.