No administrative interface for: asset.call_number_class

I like it!

To delete a given row, maybe offering a garbage can icon to click on
would be a bit more intuitive than having the user delete all text and
press enter?

You get super-bonus points if you make the fields drag'n'droppable to
define the lookup order (Lebbeous built that into the shelving
location ordering interface so there might be code to crib there); if
you go that route, an icon to the left of each field to act as the
grip affordance might work...

Alright, I've got it working on my system. There is a problem with the xulrunner however, the value is hard-coded in as I couldn't find the location to put a suitable string.

Herein lies a branch implementing a markup-based variation on Joseph's theme:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/miker/dijit_dialog_bookbag

nevermind that branch, wrong bug. SORRY!

Seems like a feature to me ... unsure on the nomination to 2.1 and 2.0

Seems like featurish bug to me. I nominated for master and 2.1, but not 2.0. If anyone thinks it shouldn't go in 2.1, I can probably be swayed. With 2.1 "so close" I can see how it might not be wanted.

Branchified

git://git.evergreen-ils.org/working/Evergreen.git

collab/dyrcona/lp787162
collab/dyrcona/lp787162_2_1

Jason - I think you forgot to add the new files to the branchified version of the patch?

We're missing:
 * Open-ILS/xul/staff_client/server/admin/asset_call_number.xhtml
 * Open-ILS/xul/staff_client/server/admin/asset_call_number.js

And I would consider this a bug fix, personally. Certainly worthy of 2.1.

Re-branchified with missing files and force pushed to the above branches.

Pushed a new branch for master to user/dbs/lp781762-call-number-class that includes the definition of an entity without which it was impossible to even open a main staff client window (due to a "popupmenu is null" error). I also provided a bit more substance to the initial commit message (that is, stating that we're adding an admin UI for call number classifications rather than just mentioning the LP #).

However, although the window will now open and the "Call Number Classifications" menu item can be found on the bottom of the Local Administration menu (not alphabetical order - we should probably sort them programmatically but that can be the substance of another bug), selecting that menu item results in a no-op. Even adding a debugging alert to the open_admin_page() function suggests that it never makes it to the open_admin_page() function.

Maybe I'm doing something wrong?

Very very quick look at what might be wrong...

I don't see anything adding a

<command id="cmd_local_admin_asset_call_number_class" />

node (with or without a perms block for auto disabling of the menu item)?

Pushed another commit onto my branch which defines the required <command> element, without which the UI could not be invoked (this is why the alert never fired in my debugging code). Now the page opens in a new tab, but dies with a pcrud exception. As this code is not ready to be merged, I'm removing the "pullrequest" tag.

See user/dbs/lp781762-call-number-class in the working repo if someone wants to tackle the next step.

I think this one should be targeted at a series/milestone, but I'm unclear which at this point.

If its a feature, then I guess it should be targeted at 2.3.

Though, with the pullrequest tag removed, I have to ask Dan what should be the status of this bug.

This interface is still missing in Evergreen 3.2.8 and 3.4.2.

I'll dust these branches off and see if they still apply/work.

Reviving discussion about this bug since we've recently had a customer who needed to make a change to an acnc row, nowadays the most straightforward way to create an admin interface would be to

1. Teach it PCRUD create, delete, and update permissions so that PCRUD can do more than just retrieve rows. I propose ADMIN_CALL_NUMBER_CLASS with global_required="true".
2. While we're in the area in fm_IDL.xml, mark required fields as required.
3. Add an Angular global admin landing page entry.