Evergreen

Patrons with Negative Balances - Deleted Patrons With Negative Balances Break Interface

Bug #2039725 reported by Jennifer Pringle on 2023-10-18

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Evergreen	New	Undecided	Unassigned

Bug Description

Evergreen 3.11

If you have deleted patrons with negative balances (and no barcodes) they break the angular Patrons with Negative Balances interface (found under Administration -> Local Administration). The list stops displaying when it hits a deleted patron without a barcode and you can no longer use any of the menu across the top of the staff client. You have to either pick a patron home library where there are no deleted patrons (if you have access to do so) or close the tab.

In the angularjs interface they display without issue.

Ideally, patrons where the deleted flag is set to true shouldn't show up in the Patrons with Negative Balances list at all.

Tags:

Revision history for this message

Jennifer Pringle (jpringle-u) wrote on 2023-10-18:

patrons-with-negative-balances-angular.png Edit (12.9 KiB, image/png)

Angular interface on 3.11

(this screenshot is from our training server - no real data)

Revision history for this message

Jennifer Pringle (jpringle-u) wrote on 2023-10-18:

patrons-with-negative-balances-angularjs.png Edit (19.4 KiB, image/png)

Angularjs interface from the same 3.11 server

Revision history for this message

Jeff Davis (jdavis-sitka) wrote on 2023-10-18:

Deleted patrons shouldn't appear in the list at all, IMO. But it looks like it is specifically patrons with no card that break the UI -- a rare circumstance, but there's no constraint in the database that prevents it (actor.usr.card can be null), so the UI ought to handle it.

Revision history for this message

Jeff Davis (jdavis-sitka) wrote on 2023-10-18:

I've shared a two-part fix in the top two commits of this branch:

working/user/jeffdavis/lp2039725-deleted-users-with-negative-balance / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp2039725-deleted-users-with-negative-balance

The first commit excludes deleted users from the open-ils.actor.users.negative_balance API response. The second commit handles patrons without barcodes in the Patrons with Negative Balances staff client interface.

tags:

added: pullrequest