Display upcoming closures on OPAC library info page

Proposed patch at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp2017913_display_closures_in_opac

Before I sign off, it does work but doesn't have time stamps for detailed closings. Not sure if that's what needs to be put in here first.

Ah, good point. We don't enter partial day closings so that hadn't occurred to me. Removing pullrequest while I tweak.

Added second commit to same branch so that it will now display hours when partial day closures are specified:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp2017913_display_closures_in_opac

Added third commit for release note.

I just tested with a variety of single, multi, and detailed closings, and everything worked great! I think this will be a welcomed feature.

My one concern is just that its formatting is wildly different from the rest of the page. The rows are very wide and take up a large portion of the page. The highlighting also makes it seem like entries are clickable.

Would it make sense to remove most of the formatting from the table (save a bit of padding) - see attached mock-up - so that it better matches the rest of the page?

I went back and forth on that because the rest of the sections of that page were ported over from the old TPAC without applying Bootstrap styling to them like most of the rest of the OPAC does. I decided to apply the Bootstrap styling that is used in the My Account pages to this table, but I agree it is very wide. I'll take a look at how to adjust that and also update the other elements on the page to be more consistent.

I modified the table display and also applied the same styling to the regular Hours display. (Also, squashed the commits.)

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp2017913_display_closures_in_opac

Looks great, Terran!

I have tested this code and consent to signing off on it with my name, John Amundson, and my email address, <email address hidden>.

I think it's looking really nice! Thanks, Terran. My only suggestion is to run cdate.reason through the | html filter, as a best practice.

Good call, Jane! Pushed additional commit with that change.

Thanks, Terran and John! Since the 3.11 feature freeze has passed, I've merged this for inclusion in 3.12.