Evergreen

SIP counts non-open transactions as fine items

Bug #2009641 reported by Jeff Davis
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Undecided
Unassigned

Bug Description

Evergreen's SIP interface uses open-ils.actor.user.transactions.history.have_balance to retrieve transactions with non-zero fines; this includes transactions that are no longer open and no longer show up in the staff client, which is probably not what you want. (Among other issues, the "fee amount" included in the SIP patron information response only includes open transactions, so the current behavior can result in Evergreen reporting multiple "fine items" but an outstanding fee amount of $0.) SIP ought to use open-ils.actor.user.transactions.have_balance instead.

Tags: needswork sip
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp2009641-sip-open-fine-items has a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp2009641-sip-open-fine-items

tags: added: pullrequest sip
Revision history for this message
Galen Charlton (gmc) wrote :

I think .../SIP/Transaction/FeePayment.pm needs to be looked at as well, as otherwise a fee payment via SIP2 might attempt to pay outstanding balances on fees whose underlying transaction is closed.

tags: added: needswork
removed: pullrequest
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.