Labels for eg-org-select combobox

Branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp1999158-org-select-labels

My approach:

- Adjust org-select.component.html to print both the <label> and the <input>

- In org-select.component.ts, provide three new input directives:
-- labelText, defaulting to "Library" (as org-family-select.component.html already did; this is localized)
-- labelClass, for additional classes like "sr-only" or layout-related classes
-- labelSuppressed, which can be set to true for instances where the <label> needs to be placed elsewhere in the layout

The rest of the files changed are instances of <eg-org-select>, which have all been updated to either remove adjacent <label> tags that are now printed automatically, or to add labelSuppressed="true" where a <label> existed but was not directly adjacent to the <input> for layout reasons.

A couple comments upon initial review of the patch:

- I double-checked and confirmed that the way we extract strings for translation recognizes $localize. Not surprising, as I don't believe that we're doing anything unusual, but I wanted to confirm.
- An i18n-labelText attribute needs to be added anywhere that labelText is used in the templates so that the label can be translated.

Thanks, Galen! I've updated the branch to catch several instances of missing i18n-labelText.

This patch breaks the holdings view due to an extraneous semicolon added into Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.html

As of the time of this testing, Evergreen is still using Bootstrap ~4.3.0 so the change from using "sr-only" to "visually-hidden" (which is introduced in Bootstrap 5.0) doesn't work and is adding visual labels to the org selectors in some places where they were hidden before (like on the Angular Staff Catalog page and the Acq PO Search Form)

For work on upgrading to Bootstrap 5.0, see: https://bugs.launchpad.net/evergreen/+bug/2000482

So, would it be best to create a new branch that implements all *but* the visually-hidden changes now and move that forward, or wait to implement any of this fix until Evergreen is updated to Bootstrap 5.0?

Also - the bug in comment #4 will need to be addressed either way.

Removing pullrequest for the time being.

I've found the stray semicolon and rebased this branch.

Getting merge conflicts on current master.

Rebased. Thanks, Terran!

If you are adding this to a test server, note that I've just updated the branch to clean up a leftover Bootstrap 4 class.

Stephanie: Too many merge conflicts for me to tackle today. Please rebase against master.

Rebased again!

I haven't checked every page that this affects, but I did notice some visibility/layout issues on the Library Settings Editor page that appear to be caused by this (see attachments).

The issue in comment #15 isn't due to the patch for this bug; it's a long-standing issue with the Angular library settings editor (as well as its AngularJS predecessor). I've opened bug 2020371 for that one.