Evergreen

patron credit payments not working

Bug #1988174 reported by Jason Etheridge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Undecided
Unassigned

Bug Description

There's an uncaught exception in master if you try to pay a bill with the Patron Credit type and the patron has no credit forward balance.

Payment was rejected: TypeError: Cannot read properties of undefined (reading 'last_xact_id')

Revision history for this message
Jason Etheridge (phasefx) wrote :

Actually, I made an assumption here that was untrue, wanting to get this bug out of my head to move on to other things. :D The error seems to happen even if you have patron credit. So a regression, maybe. Can anyone reproduce?

summary: - patron credit payments when no patron credit
+ patron credit payments not working
Terran McCanna (tmccanna)
tags: added: circ-billing patron
Revision history for this message
Garry Collum (gcollum) wrote :

I wasn't able to replicate this in current master. (Ubuntu 18.04). At least not by adding a bill to a patron account using the 'Add Bill' button, over paying with the Convert Change to Patron Credit option selected, and then adding another bill to pay by patron credit.

Revision history for this message
Jason Boyer (jboyer) wrote :

I suspect this may be distribution specific and related to the county codes commit from bug 1979357 (affects Buster and newer, which I think lines up with the 20 or 22 Ubuntu release). I haven't had time to verify that, but will try to make some now that I'm seeing this.

Revision history for this message
Jason Boyer (jboyer) wrote :

Never mind the junk comment above, that would only affect actual CC payments anyway.
In any case, I'm only able to trigger it when patron credit is 0 and I try to apply a payment.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.