Add an active flag to Acq cancel reasons

Bug #1924758 reported by Tiffany Little
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Wishlist
Unassigned

Bug Description

3.6.3+

Request to add an active flag to acquisitions cancel reasons. Once a cancel reason has been used, it can never be deleted. However, there are cancel reasons that we would prefer no longer showed in the available list when cancelling a line item or purchase order.

Changed in evergreen:
importance: Undecided → Wishlist
tags: added: acq-admin
Revision history for this message
Tiffany Little (tslittle) wrote :

I have a branch to add an active column to cancel reasons:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tlittle/LP1924758_acqcr_activeflag

The main purpose of this is to exclude not broadly used cancel reasons from user drop down lists. Many of the stock cancel reasons are reserved for EDI cancelations and cannot be deleted even if they've never been used. So the list is quite long to scroll through when really maybe only 2-4 cancel reasons are ever selected by users. EDI should still be able to use a cancel reason even if it's marked as inactive, because the ID is still there.

My question is: I used "active", but is "visible" better wording? "Staff visible?"

tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote (last edit ):

I prefer staff_visible (or maybe staff_usable, staff_applicable, manually_applicable or the like, as cancel reasons set by EDI are visible to staff when they review the PO) - "active" == false would imply that the value shouldn't be set at all.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Mary Llewellyn (mllewell) wrote :

The "active" box is present. Unchecking it labels it as "No" in the Active column in the list of Cancel Reasons.

I have tested this code and consent to signing off on it with my name, Mary Llewellyn and my email address, <email address hidden>.

Changed in evergreen:
assignee: nobody → Mary Llewellyn (mllewell)
tags: added: signedoff
Changed in evergreen:
assignee: Mary Llewellyn (mllewell) → nobody
Changed in evergreen:
assignee: nobody → Christine Morgan (cmorgan-z)
Changed in evergreen:
assignee: Christine Morgan (cmorgan-z) → nobody
Changed in evergreen:
milestone: none → 3.12-beta
Revision history for this message
Tiffany Little (tslittle) wrote :

Removing the signedoff tag for the moment. After polling the AIG meeting today, I'm going to update my branch to use "staff_visible" instead of "active."

tags: removed: signedoff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.