One Hour Gap in Default Autorenewal Delays

Bug #1899976 reported by Jason Stephenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Medium
Mike Rylander
3.10
New
Medium
Unassigned
3.11
New
Medium
Unassigned
3.9
Won't Fix
Undecided
Unassigned

Bug Description

Evergreen Version: ALL
OpenSRF Version: N/A
PostgreSQL Version: N/A
O/S Version: N/A

The default delays of "-1 minute" and "-23 hours" for the AutoRenew event definition lead to an approximately 1 hour gap where if items fall due, they will not be auto-renewed. We encountered this at CW MARS with a library where the self check was set to the wrong time zone (though it had the correct time for the time zone it should have been in) and all of the items checked out on that device fell due during this dead period based on the time that we scheduled the AutoRenew event to run.

Judicious choice of when to run the event can mask or even avoid this issue. However, it does not matter what time of the day the event runs the dead period remains, and it only takes a misconfigured client or manually edited due date to uncover it.

To fix this, I recommend modifying the seed data to change the delay for the AutoRenew event to "-24 hours 1 minute."

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Here's a branch with the change to the base schema, a db upgrade script based on an IRC conversation (http://irc.evergreen-ils.org/evergreen/2020-10-15#i_462818), and a release note:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1899976-adjust-autorenew-delay

tags: added: pullrequest
Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
Changed in evergreen:
milestone: none → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Revision history for this message
Terran McCanna (tmccanna) wrote :

I am not sure how to actually test that this resolves the problem, but I can see that the change applies cleanly to the database. My signoff is here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1899976-adjust-autorenew-delay-signoff

tags: added: signedoff
Changed in evergreen:
importance: Undecided → Medium
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
Changed in evergreen:
milestone: 3.7.2 → 3.7.3
Changed in evergreen:
milestone: 3.7.3 → 3.9-rc
assignee: nobody → Mike Rylander (mrylander)
no longer affects: evergreen/3.6
Changed in evergreen:
milestone: 3.9-rc → none
Changed in evergreen:
milestone: none → 3.9.1
Changed in evergreen:
milestone: 3.9.1 → 3.9.2
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: 3.9.2 → 3.10.1
Changed in evergreen:
milestone: 3.10.1 → 3.10.2
Changed in evergreen:
milestone: 3.10.2 → 3.9.4
milestone: 3.9.4 → 3.10.3
Changed in evergreen:
milestone: 3.10.3 → 3.12-beta
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.