Evergreen

Web Staff Client - Accessibility and the Item Edits Page

Bug #1887869 reported by Mike Risher on 2020-07-16

This bug affects 2 people

	Status	Importance	Assigned to	Milestone
Evergreen	Confirmed	Medium	Unassigned	Evergreen 3.12-beta
3.10	Confirmed	Medium	Unassigned
3.11	Confirmed	Medium	Unassigned
3.9	Won't Fix	Undecided	Unassigned

Bug Description

The page that lets you edit items and edit item templates needs to have labels added so that they're easier to use with screen readers. Check all the various input fields on these forms.

Tags:

Revision history for this message

Mike Risher (mrisher) wrote on 2020-07-17:

I pushed a branch with these changes:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1887869-item-edits-accessibility

Please note that a few of the changes rely on edits to shared directives. These edits are already done and can be found on bug 1887866.

tags:

added: pullrequest

Terran McCanna (tmccanna) on 2020-07-20

Changed in evergreen:
status:	New → Confirmed

Revision history for this message

Terran McCanna (tmccanna) wrote on 2020-08-18:

Mike, I got a merge conflict when I tried to cherry-pick this to current master. Any chance you could rebase?

Revision history for this message

Mike Risher (mrisher) wrote on 2020-08-18:

Terran, here's a branch that's been cherry picked from the current master

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1887869-item-edits-accessibility-cp

Revision history for this message

Mike Risher (mrisher) wrote on 2020-08-20:

Testing instructions:

1. You'll need a screen reader for testing. JAWS and NVDA are popular options. Instructions here: https://developer.paciellogroup.com/blog/2015/01/basic-screen-reader-commands-for-accessibility-testing/

If installing a screen reader isn't practical, Firefox can be used to test accessibility also. https://developer.mozilla.org/en-US/docs/Tools/Accessibility_inspector

2. Load changes to both the shared directives (bug #1887866) and these changes to the item edit pages (branch is in comment #3 above)

3. Test to see if the issues in the bug description have been addressed

Revision history for this message

Terran McCanna (tmccanna) wrote on 2020-09-11:

I loaded this in conjunction with the patch for lp1887866 for testing and went through the fields with the Firefox accessibility inspector and all the label names came through correctly. Thanks! My signoff is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1887869-item-edits-accessibility-cp-signoff

tags:

added: signedoff

Terran McCanna (tmccanna) on 2020-10-21

Changed in evergreen:
milestone:	none → 3.6.1
importance:	Undecided → Medium

Evergreen Bug Maintenance (bugmaster) on 2020-11-27

Changed in evergreen:
milestone:	3.6.1 → 3.6.2

Evergreen Bug Maintenance (bugmaster) on 2021-02-18

Changed in evergreen:
milestone:	3.6.2 → 3.6.3

Timothy Means (tmeans-ncc) on 2021-03-16

tags:

added: itemtemplates
removed: webstaffclient

Evergreen Bug Maintenance (bugmaster) on 2021-04-01

Changed in evergreen:
milestone:	3.6.3 → 3.6.4

Evergreen Bug Maintenance (bugmaster) on 2021-06-25

Changed in evergreen:
milestone:	3.6.4 → 3.7.2

Beth Willis (willis-a) on 2021-10-15

tags:

added: cat-templates
removed: itemtemplates

MaryAnn Alexander (maryann-alexander) on 2021-10-22

Changed in evergreen:
assignee:	nobody → MaryAnn Alexander (maryann-alexander)

MaryAnn Alexander (maryann-alexander) on 2021-10-22

Changed in evergreen:
assignee:	MaryAnn Alexander (maryann-alexander) → nobody

Evergreen Bug Maintenance (bugmaster) on 2021-10-29

Changed in evergreen:
milestone:	3.7.2 → 3.7.3

Evergreen Bug Maintenance (bugmaster) on 2022-05-23

no longer affects:	evergreen/3.6
Changed in evergreen:
milestone:	3.7.3 → none

Terran McCanna (tmccanna) on 2022-10-03

Changed in evergreen:
milestone:	none → 3.9.1

Evergreen Bug Maintenance (bugmaster) on 2022-11-03

Changed in evergreen:
milestone:	3.9.1 → 3.9.2

Michele Morgan (mmorgan) on 2023-02-15

Changed in evergreen:
milestone:	3.9.2 → 3.10.1

Evergreen Bug Maintenance (bugmaster) on 2023-03-27

Changed in evergreen:
milestone:	3.10.1 → 3.10.2

Revision history for this message

Galen Charlton (gmc) wrote on 2023-05-16:

Will commit when the merge window reopens after the May releases.

Changed in evergreen:
assignee:	nobody → Galen Charlton (gmc)

Revision history for this message

Stephanie Leary (stephanieleary) wrote on 2023-05-18:

Looking more closely, the ARIA labeling strategy needed significant revision. I have a WIP branch at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=b96e0d127919a673829d11ae990177c7a510bd80 but this needs additional review and testing.

tags:

added: needswork
removed: signedoff

Galen Charlton (gmc) on 2023-05-18

Changed in evergreen:
assignee:	Galen Charlton (gmc) → nobody

Andrea Neiman (aneiman) on 2023-05-18

tags:

removed: pullrequest

Evergreen Bug Maintenance (bugmaster) on 2023-05-18

Changed in evergreen:
milestone:	3.10.2 → 3.10.3

Jason Stephenson (jstephenson) on 2023-06-07

Changed in evergreen:
milestone:	3.10.3 → 3.12-beta

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.