Evergreen

Carousel Types - Shelving Location Terminology

Bug #1853630 reported by Terran McCanna
28
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Undecided
Unassigned

Bug Description

In 3.4.1:

In the Admin > Server Admin > Carousel Types interface, "Filter By Item Location" should be "Filter by Shelving Location" for consistency with other Evergreen interfaces.

John Amundson (jamundson)
Changed in evergreen:
status: New → Confirmed
Terran McCanna (tmccanna)
tags: added: admin-pages opac-carousel
removed: carousel
Revision history for this message
Gina Monti (gmonti90) wrote :

Here's my branch. Po files have also been updated:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=14ce02c0c62f0d99356e72fd20800890516b3649

tags: added: pullrequest
Revision history for this message
Mary Llewellyn (mllewell) wrote (last edit ):

I'm still seeing "Filter By Item Location?". I've cleared my cache, but no change.

Tested in https://tiffany-master.gapines.org/

Changed in evergreen:
assignee: nobody → Mary Llewellyn (mllewell)
Mary Llewellyn (mllewell)
Changed in evergreen:
assignee: Mary Llewellyn (mllewell) → nobody
Revision history for this message
Christine Burns (christine-burns) wrote :

I'm also still seeing "Filter By Item Location?". I've cleared my cache, but no change.

Tested in https://tiffany-master.gapines.org/

Revision history for this message
Terran McCanna (tmccanna) wrote :

Removing pull request. This still needs an upgrade script for the seed data, and I believe the changes to the .po files shouldn't be included since those changes are done through the translation mechanism rather than through direct code changes here.

tags: removed: pullrequest
tags: added: needswork
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.