Comment 6 for bug 1843632

Hi Shula, I have some feedback about your changes.

First, the initial issue is caused in part by the IDL file in Open-ILS/examples/fm_IDL.xml that doesn't appear to be addressed by your patch, so that will need to be looked at. There are several reporter:label fields still set to Copy Location.

Even though changing comments won't generally be visible to end users changing them is a good idea to keep devs from accidentally re-introducing old terminology.

All of the past upgrade scripts and the translations can (and should) be ignored. Any non-comment changes made to the files in Open-ILS/src/sql/Pg/ would also be performed in a new file you write and put in the upgrade directory. (It looks like that's just the stuff in 950.data.seed-values.sql currently.) The reason for this is that old upgrade scripts are treated as if they're encased in stone; if you want to make new changes you just need to add a new upgrade script to the list. There have been a couple times that this convention has been broken but that's usually to prevent unexpected data loss or crashes discovered after an upgrade.

Translations can be ignored because they'll be rebuilt automatically from your changes to other files.