Angularize the Self-Check Interface

FYI, Bill and I are having a roundtable discussion at the April 2020 Evergreen Conference to discuss overhauling the entire self-check interface. Interested parties, please come!

Marking this won't fix for the moment I'm working on compiling all the feedback from last year's Evergreen Conference session

Thanks to Terran for compiling notes. Working now to review, etc.

I have a working branch that's ready for eyeballs with a few caveats.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1840773-scko-angular-v2

* It's built atop the branch for bug #1904036 so it can use some of its code.

* No new features are implemented. It's just meant to be a direct port at this point.

* It does not yet support workstation logins / management. We need to decide if Hatch should be available to SCKO. Currently, it's not and will require an app store extension change.

The code is essentially part of the Angular staff client application (under /eg2/scko), but the auth token is stored under a separate key from the browser client or the catalog, so access to one does not allow access to the other.

This does not remove any of the existing SCKO UI code, so merging this to EG mainline does not mean it has to be used, which could ease its passage into the core code (but that assumes bug #1904036 is merged or the needed bits are extracted).

To address the Hatch issue, I'm rearranging the directory structure to put the 'scko' module under the /staff/ directory, which Hatch already has access to. It will not be part of the staff client proper, though, because it uses a different base module.

Several more commits pushed to branch in my previous comment - 1. (My penultimate comment?)

SCKO app now sits under /staff/scko, which give is access to Hatch for workstations management and printing. (Note, hatch is still not required, just available).

A new link is added to the scko staff login page for Manage Workstations, which opens a new tab to the actual staff client for workstation management.

A pile of other small fixes, etc. as well.

Adding a pullrequest because I believe the code has reached parity with the Dojo version. If needed, we can open new bugs for the new features.

New branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1840773-scko-angular-v3

1. Rebased to latest branch for bug #1904036
2. Adds support for in-place batch renewals in the items out page.
3. Adds message for login failures.

I forgot to mention in a previous comment that this implementation does move the username + password inputs into the same interface, as requested in the bug description.

Tested + signed off by me.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=79e6eb18a0ec6dcd2befac8e6ff74a0a2effe57b

Actually, I've found some issues, so I'm going to remove the signoff. Will update with my details here shortly.

1) The workstation management option appears as expected. However, when the library setting "Workstation Required" is set to True, it does not require a workstation. (Old version gives workstation registration prompt when this setting is True.) Should this setting still work?

2) Logout doesn't work if print radio button is selected - gives error compiling print template. (Logout with the Email or None works, although I don't think outgoing email is enabled on this test server, so I haven't tested the email functionality.)

3) The option to email receipts appears to be tied to the "Email receipts by default" flag rather than to the presence of an email in the account like the current self-check is. (My test patron has an email address saved, but the email option doesn't appear in the Angular self-check unless I also check the email by default checkbox in the patron account.)

(I'm not connected to a printer today, but will check printing functionality tomorrow.)

But for good news, having the username & password on the same screen is a big improvement and it's really nice to be able to do renewals!!

4) After entering a barcode to checkout, I would expect it to disappear from the scan box but it stays there.

2 Update) Testing from a computer that has a printer attached today - I can now log out without getting the print compile error, so I'm not sure if something has been fixed or if it depends on whether or not a printer is attached?

5) If I log out and then log in with another user, the last barcode I scanned is still in the entry box.

6) Printing is functional, but the font size is so tiny as to make it unusable (see attached). (I confirmed that my normal receipt printer settings are correct by printing from the AngularJS patron interface. Printing from the new Angular patron interface also prints in a tiny font, but I'll report that elsewhere.

FYI - here is a working document that summarizes various meetings and LP tickets: https://docs.google.com/document/d/191G7UKAr7ShPaZ1J-YXW43TRbJjH79C_GNbjSI9nJv8/edit

This doesn't seem quite ready for the 3.10 slush, but setting it to 3.next because it seems like it will be in good shape for 3.11!