Web Client: Workstation dropdowns are not alphabetical

Just a note that this should probably be fixed for both Evergreen/Open-ILS/src/templates/staff/t_login.tt2 and Evergreen/Open-ILS/src/templates/staff/admin/workstation/t_workstations.tt2 (aka at the main login screen and also in Administration > Workstation > Registered Workstations).

I have a potential fix at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/slink/LP1722383_web_client_workstation_dropdowns_are_not_alphabetical

I'm putting in a Sandbox request to see if it works, or if there's unintended side effects.

Sandbox testing indicates that adding an orderBy filter using the "name" attribute does not provide alphabetical sorting. I've pushed a new commit to the above branch to try a different approach to the sorting.

The prior commit did not work, so I'm taking another swing at the sorting. Commit has been pushed to the above branch. Again.

And I'm stepping away for now. The commit history of that branch will give three examples of nonworking solutions.

I've grabbed this again during bug squashing day here. Possible fix @

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=e94129dc27d794e456cd116fd8316ccea3fe110b

I am testing this bug patch.

Dawn confirmed the patch as not working:

The issue I'm seeing is in what information exists in an Angular "workstation" object - the "ws" in "ws in workstations" does not openly contain any name data for the branches. Moreover, I have concerns that successfully sorting by branch may break the default workstation being first in the dropdown.

Looking at the code, a function has to be called to generate the actual workstation name - the {{get_ws_label(ws)}} line in the template - so I'm leaning towards actually fixing this is a larger project than it appears on the surface.