webstaff - do not translate username and workstation in navbar
Bug #1710991 reported by
Ben Shum
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
Evergreen master
Discovered during troubleshooting in bug 1629078, we found that the username @ workstation is being translated from the web staff client's navbar, but this causes problems with rendering the content since it expects it to be variables, not an actual translated value.
In this file -- Open-ILS/
[% l('{{username}} @ {{workstation}}') %]
If we remove the l() localization for translation and leave it just regular variables, the web client renders the menus correctly when translating to other languages.
Branch forthcoming.
| Changed in evergreen: | |
| milestone: | none → 3.0-alpha |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| summary: |
- webstaff - do not translate username and workstation + webstaff - do not translate username and workstation in navbar |
Revision history for this message
| Ben Shum (bshum) wrote | #1 |
| tags: | added: pullrequest |
| Changed in evergreen: | |
| assignee: | nobody → Galen Charlton (gmc) |
Revision history for this message
| Galen Charlton (gmc) wrote | #2 |
| Changed in evergreen: | |
| status: | Confirmed → Fix Committed |
| assignee: | Galen Charlton (gmc) → nobody |
| Changed in evergreen: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Working branch: user/bshum/
http://
Removing the localization from the template fixes the problem. The next POT sync will remove the string from the templates for translation.
Unsure if it should be styled in any special way, or if we need any other tweaks for this fix. But it was the quickest solution.