Holds history breaks when old holds connect to a deleted target

Bug #1642341 reported by Blake GH
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Medium
Unassigned

Bug Description

/usr/sbin/apache2 [ERR :55401:EX.pm:66:147931340355401261] Exception: OpenSRF::EX::ERROR 2016-11-16T11:21:07 OpenSRF::AppRequest /usr/local/share/perl/5.18.2/OpenSRF/AppSession.pm:1086 System ERROR: Exception: OpenSRF::DomainObject::oilsMethodException OpenSRF::AppRequest /usr/local/share/perl/5.18.2/OpenSRF/AppSession.pm:1086 <500> *** Call to [open-ils.circ.hold.details.retrieve] failed for session [1479316864.1130340167.7766207604], thread trace [1]:
Can't call method "id" on an undefined value at /usr/local/share/perl/5.18.2/OpenILS/Application/Circ/Holds.pm line 3412.

Here is the sql that identifies this situation:

select * from action.hold_request where usr in(
select id from actor.usr where usrname='TESTPATRON'
)
-- and hold_type='M' and target not in(select id from metabib.metarecord)
-- and hold_type='P' and target not in(select id from biblio.monograph_part)
-- and hold_type='C' and target not in(select id from asset.copy where not deleted)
and hold_type='T' and target not in(select id from biblio.record_entry where not deleted)
order by hold_type

Uncomment the hold type lines one at a time until you find the type that returns row(s)

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I'm seeing this on 2.12.8, and I'm fairly confident it continues to be an issue in later releases.

tags: added: holds opac
Revision history for this message
Jessica Woolford (jwoolford) wrote :

Just had a report of this in 3.1.16.

Dan Briem (dbriem)
tags: added: circ-holds
removed: holds
Revision history for this message
Michele Morgan (mmorgan) wrote :

Master ca 3.9

This is no longer an issue for holds of type T, C, and P. But M type holds are still problematic. I'm marking this as a duplicate of bug 1441301.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.