I pushed a follow-up commit to the working branch, changing the login_type for AuthProxy SIP logins from "sip" to "opac". The "sip" login type does not exist and adding it is beyond the scope of this bug; non-AuthProxy SIP logins already use "opac" as the login type, so it seems reasonable to stick with that. However, that means you can't specify a separate login type for SIP in AuthProxy config -- if AuthProxy is enabled for OPAC logins, it will automatically be used for SIP as well.
Working branch user/jeffdavis/auth_proxy_test has a simple AuthProxy test authenticator that may be useful for testing this new feature.
I pushed a follow-up commit to the working branch, changing the login_type for AuthProxy SIP logins from "sip" to "opac". The "sip" login type does not exist and adding it is beyond the scope of this bug; non-AuthProxy SIP logins already use "opac" as the login type, so it seems reasonable to stick with that. However, that means you can't specify a separate login type for SIP in AuthProxy config -- if AuthProxy is enabled for OPAC logins, it will automatically be used for SIP as well.
Working branch user/jeffdavis/ auth_proxy_ test has a simple AuthProxy test authenticator that may be useful for testing this new feature.